From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.keller@gmail.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
Git mailing list <git@vger.kernel.org>,
Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH 05/11] completion: add test showing subpar completion for git switch --orphan
Date: Tue, 28 Apr 2020 13:57:17 -0700 [thread overview]
Message-ID: <xmqqlfmf1g7m.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CA+P7+xpD7LaYMnoi6L-Z7e9w0j0+ppDCw6fGBzSMfxerw0HrUA@mail.gmail.com> (Jacob Keller's message of "Tue, 28 Apr 2020 13:41:44 -0700")
Jacob Keller <jacob.keller@gmail.com> writes:
> I assumed completion would be most useful to complete the start-point,
> and so I opted to lean towards fixing completion for -c/-C to complete
> all references. However, I don't think the branch name should
> necessarily complete from all references and it would make sense to
> complete that portion only by local branch names.
>
> I'm just not sure how best to implement that in our completion logic,
> and I would rather ensure that start-point completes properly, if we
> have to choose.
Sure. What I was saying that if it is easier to implement by
completing both new branch name and starting point from the same
set, you could choose to include both branches and tags, and your
"excuse" for choosing that design could be that a user who wants to
fix something in 2.26 release may want the completion and typing
progression go like so:
$ git switch -c v2.2<TAB>
... offers v2.20, v2.21, ..., v2.26 as candidates
... complete to v2.26 and type "-frotz-fix"
$ git switch -c v2.26-frotz-fix
$ git switch -c v2.26-frotz-fix v2.2<TAB>
... again offers v2.20, v2.21, ..., v2.26
;-)
next prev parent reply other threads:[~2020-04-28 20:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 2:20 [PATCH 00/11] refactor git switch completion Jacob Keller
2020-04-25 2:20 ` [PATCH 01/11] completion: add some simple test cases for " Jacob Keller
2020-04-25 2:20 ` [PATCH 02/11] completion: add test showing subpar " Jacob Keller
2020-04-25 2:20 ` [PATCH 03/11] completion: add test highlighting subpar git switch --track completion Jacob Keller
2020-04-25 2:20 ` [PATCH 04/11] completion: add tests showing lack of support for git switch -c/-C Jacob Keller
2020-04-25 2:20 ` [PATCH 05/11] completion: add test showing subpar completion for git switch --orphan Jacob Keller
2020-04-27 23:34 ` Junio C Hamano
2020-04-28 2:12 ` Jacob Keller
2020-04-28 2:20 ` Jacob Keller
2020-04-28 16:24 ` Junio C Hamano
2020-04-28 17:32 ` Jacob Keller
2020-04-28 18:10 ` Junio C Hamano
2020-04-28 18:45 ` Jacob Keller
2020-04-28 19:16 ` Junio C Hamano
2020-04-28 20:41 ` Jacob Keller
2020-04-28 20:57 ` Junio C Hamano [this message]
2020-04-25 2:20 ` [PATCH 05/11] completion: remove " Jacob Keller
2020-04-25 2:20 ` [PATCH 06/11] completion: rename --track option of __git_complete_refs Jacob Keller
2020-04-25 2:20 ` [PATCH 07/11] completion: extract function __git_dwim_remote_heads Jacob Keller
2020-04-25 2:20 ` [PATCH 08/11] completion: perform DWIM logic directly in __git_complete_refs Jacob Keller
2020-04-25 2:20 ` [PATCH 09/11] completion: fix completion for git switch with no options Jacob Keller
2020-04-25 2:20 ` [PATCH 10/11] completion: recognize -c/-C when completing for git switch Jacob Keller
2020-04-25 2:20 ` [PATCH 11/11] completion: complete remote branches for git switch --track Jacob Keller
2020-04-25 22:14 ` [PATCH 00/11] refactor git switch completion Jacob Keller
2020-04-30 22:56 ` Junio C Hamano
2020-05-01 21:53 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlfmf1g7m.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jacob.keller@gmail.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).