From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25A50C3F2CE for ; Wed, 4 Mar 2020 16:20:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA92D215A4 for ; Wed, 4 Mar 2020 16:20:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="sE0S3grm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387860AbgCDQUL (ORCPT ); Wed, 4 Mar 2020 11:20:11 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:63660 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726764AbgCDQUK (ORCPT ); Wed, 4 Mar 2020 11:20:10 -0500 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id B54034981E; Wed, 4 Mar 2020 11:20:08 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=L0BNjhUlqWhhoRkCdMN+mFJL91I=; b=sE0S3g rm/SnhxeaUhduQ++79E+1Ix6FkKCSGZURoyNa5hZSylgUc/4Z8kSPhcWGEq9wUAX EvdDyp2CxcYW51aNfji7bTQhV28LMdcGCrmeTc1klDplxwkBeJ8f5Jl1eObF/bHP dD3sB6nwnGoyyJClMdX6C5uET65F30eL+SON8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=jt0hL+qjKd/3NQnfu2/8SlJiIdqTwAgL Bb7f+m4SuE/ETRhdN2WIhKRcPeOQn2sAvnfIIjmwvBsffgUUgh7hRyUB7oqsT/f9 osTaeAZQHicEOYJ32QrTOuvP9bwe2ftKPU6FGiKbW6wXzmHos1ok2EmlIF4Cw2Un 5Cw05Zgjxec= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 92E454981D; Wed, 4 Mar 2020 11:20:08 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.76.80.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id AB9D24981B; Wed, 4 Mar 2020 11:20:04 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Eric Sunshine Cc: Hariom Verma via GitGitGadget , Git List , Hariom Verma Subject: Re: [PATCH] t2402: test worktree path when called in .git directory References: Date: Wed, 04 Mar 2020 08:20:02 -0800 In-Reply-To: (Eric Sunshine's message of "Wed, 4 Mar 2020 03:15:05 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 01A69EAE-5E34-11EA-9600-D1361DBA3BAF-77302942!pb-smtp2.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Eric Sunshine writes: > On Wed, Mar 4, 2020 at 2:00 AM Hariom Verma via GitGitGadget > wrote: >> The bug which reports an extra `/.git/.` in worktree path when called in >> '.git' directory already has been fixed. But unfortunately, the regression >> test to ensure this behavior has been forgotten. >> Here is that test. > > For readers not involved in the discussion, this test was requested by > [1], but the topic graduated to "next" before it could be re-rolled. > It probably ought to be queued atop > 'hv/receive-denycurrent-everywhere'. > > [1]: https://lore.kernel.org/git/CAPig+cTh-uu-obh9aeDOV9ptbVwRmkujgucbu9ei1Qa3qSNG_A@mail.gmail.com/ Your notes to those watching from sidelines are greatly appreciated. >> Signed-off-by: Hariom Verma >> --- >> diff --git a/t/t2402-worktree-list.sh b/t/t2402-worktree-list.sh >> @@ -151,4 +151,10 @@ test_expect_success 'linked worktrees are sorted' ' >> +test_expect_success 'worktree path when called in .git directory' ' >> + git worktree list> list1 && >> + git -C .git worktree list> list2 && > > Nit: Style is for the redirection operator to stick to the file: ;-) Thanks for being a careful reader. > git worktree list >list1 && > git -C .git worktree list >list2 && > >> + test_cmp list1 list2 >> +' > > The test itself makes sense.