git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] doc/fsck: discuss mix of --connectivity-only and --dangling
Date: Fri, 01 Mar 2019 11:50:31 +0900	[thread overview]
Message-ID: <xmqqlg1z9uko.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: 20190227145928.GA3727@sigill.intra.peff.net

Jeff King <peff@peff.net> writes:

> I'm actually a little torn on this. We could consider this a bug, and
> the "option" to disable it when you want things to go fast is to say
> "--no-dangling". That leaves no way to say "show me the list of
> unreachable objects, but don't bother spending extra time on dangling
> analysis". But I don't think I've ever really wanted that list of
> unreachable objects anyway (and besides, you could do it pretty easily
> with cat-file, rev-list, and comm).
>
> So I sketched up what it might look like to just fix the bug (but kick
> in only when needed), which is below.

[jch: I am still mostly offline til the next week, but I had a
chance to sit in front of my mailbox long enough, so...]

As the primariy purose of the --conn-only option being such, perhaps
we should have made --no-dangling the default when --conn-only is in
effect.

But if --conn-only is made to do the right thing while showing
dangling and unreachable properly sifted into their own bins, like
this patch does, what's the difference between that and the normal
--no-conn-only, other than performance and corrupt blobs left
unreported?  Perhaps if we are going that route, it might even make
sense to rename --conn-only to --skip-parsing-blobs or something.

Thanks.


  reply	other threads:[~2019-03-01  2:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-27 14:55 [PATCH] doc/fsck: discuss mix of --connectivity-only and --dangling Jeff King
2019-02-27 14:59 ` Jeff King
2019-03-01  2:50   ` Junio C Hamano [this message]
2019-03-05  4:26     ` Jeff King
2019-03-05  4:45       ` [PATCH v2 0/2] fsck --connectivity-only --dangling Jeff King
2019-03-05  4:46         ` [PATCH v2 1/2] doc/fsck: clarify --connectivity-only behavior Jeff King
2019-03-05  4:47         ` [PATCH v2 2/2] fsck: always compute USED flags for unreachable objects Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlg1z9uko.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).