From: Junio C Hamano <gitster@pobox.com>
To: james harvey <jamespharvey20@gmail.com>
Cc: git@vger.kernel.org, sbeller@google.com
Subject: Re: Using --word-diff breaks --color-moved
Date: Wed, 31 Oct 2018 13:27:33 +0900 [thread overview]
Message-ID: <xmqqlg6eyc3u.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CA+X5Wn76N34oBhRZvXKOwP0L_pF=LYbT6ugTgtPYSvnHg=MZVw@mail.gmail.com> (james harvey's message of "Tue, 30 Oct 2018 22:05:48 -0400")
james harvey <jamespharvey20@gmail.com> writes:
> If you use both "--word-diff" and "--color-moved", regardless of the
> order of arguments, "--word-diff" takes precedence and "--color-moved"
> isn't allowed to do anything.
>
> I think "--color-moved" should have precedence over "--word-diff". I
> cannot think of a scenario where a user would supply both options, and
> actually want "--word-diff" to take precedence.
I am not sure if I follow. If these two cannot work well together,
then we should just reject the request as asking for incompatible
combination of options while we are parsing the command line
arguments, rather than arguing which one should trump the other
one---that would simply lead to "in my opinion, word-diff is more
important" vs "in mine, color-moved is more important", no?
next prev parent reply other threads:[~2018-10-31 4:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 2:05 Using --word-diff breaks --color-moved james harvey
2018-10-31 4:27 ` Junio C Hamano [this message]
2018-10-31 7:07 ` james harvey
2018-10-31 17:43 ` Stefan Beller
2018-10-31 17:41 ` Stefan Beller
2018-11-02 1:18 ` james harvey
2018-11-02 20:46 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlg6eyc3u.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jamespharvey20@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).