From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: gitgitgadget@gmail.com, git <git@vger.kernel.org>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/1] t7406: avoid failures solely due to timing issues
Date: Mon, 23 Jul 2018 14:31:49 -0700 [thread overview]
Message-ID: <xmqqlga14p16.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAGZ79kag=YC6PxOnBbVAqY92dNd5yuqfvash-oPVrEktowNbVA@mail.gmail.com> (Stefan Beller's message of "Mon, 23 Jul 2018 13:53:10 -0700")
Stefan Beller <sbeller@google.com> writes:
> This test was last touched in c66410ed32a (submodule init:
> redirect stdout to stderr, 2016-05-02), merged as f2c96ceb57a
> (Merge branch 'sb/submodule-init', 2016-05-17)
>
> The parallelizing effort was made before that
> (2335b870fa7 (submodule update: expose parallelism to the
> user, 2016-02-29) via bdebbeb3346 (Merge branch
> 'sb/submodule-parallel-update', 2016-04-06)), but did not
> review existing tests for the newly introduced raciness.
Ah, that explains what I was scratching my head about. I somehow
thought that the parallel update broke an otherwise working test
written back in the serial days, but it seems it was the other way
around. The test was simply careless.
Nice to have the two-year old issue fixed. Thanks, all.
next prev parent reply other threads:[~2018-07-23 21:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 13:39 [PATCH 0/1] t7406: avoid failures solely due to timing issues Johannes Schindelin via GitGitGadget
2018-07-23 13:39 ` [PATCH 1/1] " Johannes Schindelin via GitGitGadget
2018-07-23 19:14 ` Junio C Hamano
2018-07-23 20:53 ` Stefan Beller
2018-07-23 21:31 ` Junio C Hamano [this message]
2018-07-23 19:10 ` [PATCH 0/1] " Junio C Hamano
2018-07-24 9:00 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlga14p16.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).