git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Segfault in the attr stack
Date: Wed, 01 Jun 2016 15:35:08 -0700	[thread overview]
Message-ID: <xmqqlh2ownab.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kZ6dh7AP5b5N_2RRHQmq=OKpr05JEwyOCbfOj6KWjFC2A@mail.gmail.com> (Stefan Beller's message of "Wed, 1 Jun 2016 15:29:49 -0700")

Stefan Beller <sbeller@google.com> writes:

> I propose to not escape commas, but use
> white spaces instead, i.e.
>
>     git status ':(attr:whitespace=indent trail space,attr:label=with
> more values)' ':attr(attr:foo:bar)'
>
> would match
> * all files that have the whitespace AND the label setting (matching
> exactly the values)

"attr:whitespace=indent trail ..whatever other stuff.." is already a
non-starter.  In the example in the message you are responding to, I
want to find paths whose "whitespace" attribute is set to the exact
string "indent,trail,space".  And I do not want the pathspec magic
code to know how the interpretation of "whitespace" attribute treats
comma in the string.  It may or may not have any special meaning, so
if you meant "whitespace=indent trail ..whatever other stuff.."  to
mean "either whitespace is set to indent, or whitespace is set to
trail", then that is already unacceptable.

  reply	other threads:[~2016-06-01 22:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01 22:00 Segfault in the attr stack Stefan Beller
2016-06-01 22:11 ` Junio C Hamano
2016-06-01 22:29   ` Stefan Beller
2016-06-01 22:35     ` Junio C Hamano [this message]
2016-06-01 22:11 ` Stefan Beller
2016-06-01 22:17   ` Junio C Hamano
2016-06-01 22:46     ` Junio C Hamano
2016-06-02  0:22       ` Junio C Hamano
2016-06-02 15:59         ` Junio C Hamano
2016-06-02 16:56           ` Stefan Beller
2016-06-02  1:02     ` Duy Nguyen
2016-06-02  1:04       ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlh2ownab.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).