git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
	git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>,
	Philip Oakley <philipoakley@iee.org>,
	Gunnar Wagner <gunnar.wagner@irisgermanica.com>
Subject: Re: [PATCHv2] commit: reword --author error message
Date: Mon, 26 Jan 2015 18:43:46 -0800	[thread overview]
Message-ID: <xmqqlhkplz8d.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150126190711.GA13582@peff.net> (Jeff King's message of "Mon, 26 Jan 2015 14:07:12 -0500")

Jeff King <peff@peff.net> writes:

> ... I somehow had trouble making
> sense of Z ("a match...") as a noun.

> I wonder if adding back in the missing verb, rather than a colon, would
> also make more sense:
>
>   --author '%s' is neither 'Name <email>' nor a match for an existing author

Then

>   --author '%s' is not 'Name <email>' and matches no existing author

would be the shortest, sweetest and hopefully grammatical, perhaps?

  reply	other threads:[~2015-01-27  2:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13  8:15 commit --amend --author error Gunnar Wagner
2015-01-13 11:24 ` Michael J Gruber
2015-01-14 12:09   ` Jeff King
2015-01-15 14:21     ` Michael J Gruber
2015-01-15 14:23       ` [PATCH] commit: reword --author error message Michael J Gruber
2015-01-15 14:25         ` Michael J Gruber
2015-01-15 14:31         ` Jeff King
2015-01-15 14:40           ` Michael J Gruber
2015-01-15 17:48         ` Junio C Hamano
2015-01-16  9:32           ` Jeff King
2015-01-16 17:29             ` Junio C Hamano
2015-01-16 18:33               ` Philip Oakley
2015-01-16 18:35                 ` Junio C Hamano
2015-01-16 19:37                   ` Eric Sunshine
2015-01-16 19:53                     ` Junio C Hamano
2015-01-26 15:48                       ` [PATCHv2] " Michael J Gruber
2015-01-26 19:07                         ` Jeff King
2015-01-27  2:43                           ` Junio C Hamano [this message]
2015-01-27  2:45                             ` Jeff King
2015-01-27  8:37                               ` Philip Oakley
2015-01-27 12:22                           ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlhkplz8d.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gunnar.wagner@irisgermanica.com \
    --cc=peff@peff.net \
    --cc=philipoakley@iee.org \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).