From: Junio C Hamano <gitster@pobox.com>
To: Jim Hill <gjthill@gmail.com>
Cc: git@vger.kernel.org, Aaron Schrab <aaron@schrab.com>
Subject: Re: [PATCH w/signoff] pre-push.sample: Remove unwanted `IFS=' '`.
Date: Sun, 21 Dec 2014 14:49:53 -0800 [thread overview]
Message-ID: <xmqqlhm0botq.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAEE75_0Ff7NfQYUPrA414N9E0AE6LsS2zs0kL=BJ25bjPgom_w@mail.gmail.com> (Jim Hill's message of "Sun, 21 Dec 2014 11:12:45 -0800")
Jim Hill <gjthill@gmail.com> writes:
> I call it unwanted because the default works fine with the actual
> input and explicitly limiting whitespace this way breaks most command
> substitution.
OK. I'd call that "unnecessary", not "unwanted", though.
It becomes unwanted only when somebody cuts and pastes and changes
what happens inside the body of the loop without thinking what IFS
assignment is doing.
Leaving it to the default is not wrong per-se, but I think it is
better to justify this change as protecting cut-and-paste people,
which is its primary benefit as far as I can see.
Thanks for noticing.
next prev parent reply other threads:[~2014-12-21 22:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-21 18:14 [PATCH] pre-push.sample: Remove unwanted `IFS=' '` Jim Hill
2014-12-21 18:25 ` [PATCH w/signoff] " Jim Hill
2014-12-21 18:50 ` Junio C Hamano
2014-12-21 19:12 ` Jim Hill
2014-12-21 22:49 ` Junio C Hamano [this message]
2014-12-23 2:08 ` Junio C Hamano
2014-12-21 19:26 ` [PATCH v2] pre-push.sample: remove " Jim Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlhm0botq.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=aaron@schrab.com \
--cc=git@vger.kernel.org \
--cc=gjthill@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).