git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] remote-helpers: point at their upstream repositories
Date: Tue, 20 May 2014 14:50:33 -0700	[thread overview]
Message-ID: <xmqqlhtwrufq.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <537bc8ea6ced9_1d08f2d2f8fd@nysa.notmuch> (Felipe Contreras's message of "Tue, 20 May 2014 16:28:10 -0500")

Felipe Contreras <felipe.contreras@gmail.com> writes:

> Junio C Hamano wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>> ...
>> > So to make it clear, I now request that you do:
>> >
>> >  1) Remove all the code.
>> ...
>> I'll do that, but just one thing to make sure---do you want the
>> helper to exit with status 0?
>
> It doesn't matter; if the remote helper doesn't respond to the commands
> transport-helper exits with 128.

You're right.

>> >  4) Re-add the following release note:
>> >
>> >     * "git push" via transport-helper interface (e.g. remote-hg) has
>> >       been updated to allow forced ref updates in a way similar to the
>> >       natively supported transports
>> 
>> I am not sure if this one is consistent with 1), as remote-hg will
>> no longer be with the release.
>
> Remove '(e.g. remote-hg)', the rest still applies.

True enough.

I was already deep in today's -rc4 tagging before this exchange, so
it may be a while until the result is pushed out, but as far as I
know the helpers are now stubs, and README no longer says "a random
version that will go stale is kept here merely for convenience".

As additional topics that touch contrib/remote-helpers/ need to be
reverted from 'next', the final pushout may take longer than usual.
We'll see.

  reply	other threads:[~2014-05-20 21:50 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-15 22:56 [PATCH] remote-helpers: point at their upstream repositories Junio C Hamano
2014-05-16  7:37 ` Felipe Contreras
2014-05-16  8:41 ` Jeff King
2014-05-16  8:55   ` Paolo Ciarrocchi
2014-05-16  8:59     ` Jeff King
2014-05-16  9:03     ` Felipe Contreras
2014-05-16  9:23   ` Felipe Contreras
2014-05-16 16:52   ` Junio C Hamano
2014-05-16 22:39     ` Felipe Contreras
2014-05-17  2:11       ` James Denholm
2014-05-17  5:24         ` Felipe Contreras
2014-05-18  1:24           ` James Denholm
2014-05-18  2:31             ` Felipe Contreras
2014-05-18 23:05       ` Junio C Hamano
2014-05-19  1:19         ` Felipe Contreras
2014-05-19 21:31           ` Junio C Hamano
2014-05-20 14:55             ` Michael Haggerty
2014-05-20 15:20               ` Johan Herland
2014-05-20 21:31                 ` Felipe Contreras
2014-05-20 20:52             ` Felipe Contreras
2014-05-16 22:52     ` Jeff King
2014-05-17  5:25       ` Felipe Contreras
2014-05-17  6:24         ` Jeff King
2014-05-17 17:15           ` Felipe Contreras
2014-05-18 17:34             ` Matthieu Moy
2014-05-18 22:48               ` Felipe Contreras
2014-05-18 23:13           ` Junio C Hamano
2014-05-19  1:31             ` Felipe Contreras
2014-05-19  6:11               ` Junio C Hamano
2014-05-19 21:21                 ` Felipe Contreras
2014-05-19 22:27                   ` Junio C Hamano
2014-05-19 23:17                     ` Junio C Hamano
2014-05-20  2:06                       ` Felipe Contreras
2014-05-20  4:32                         ` Junio C Hamano
2014-05-19 19:01               ` Junio C Hamano
2014-05-20 20:39                 ` Felipe Contreras
2014-05-20 21:11                   ` Junio C Hamano
2014-05-20 21:28                     ` Felipe Contreras
2014-05-20 21:50                       ` Junio C Hamano [this message]
2014-05-16 18:07   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqlhtwrufq.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).