From: Junio C Hamano <gitster@pobox.com>
To: "Jean-Noël AVILA" <jn.avila@free.fr>
Cc: Jiang Xin <worldhello.net@gmail.com>,
Git List <git@vger.kernel.org>,
Sebastien Helleu <flashcode@flashtux.org>
Subject: Re: [GIT PULL] hotfix on fr.po for the maint branch
Date: Fri, 30 Aug 2013 11:07:06 -0700 [thread overview]
Message-ID: <xmqqli3jyrw5.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <21533323.C8UgJI1nMs@cayenne> ("Jean-Noël AVILA"'s message of "Fri, 30 Aug 2013 19:23:54 +0200")
Jean-Noël AVILA <jn.avila@free.fr> writes:
> Le vendredi 30 août 2013 09:54:59 Junio C Hamano a écrit :
>> Jiang Xin <worldhello.net@gmail.com> writes:
>> > Please merge this commit to the maint branch.
>> >
>> > The following changes since commit
> e230c568c4b9a991e3175e5f65171a566fd8e39c:
>> > Git 1.8.4 (2013-08-23 11:49:46 -0700)
>> >
>> > are available in the git repository at:
>> > git://github.com/git-l10n/git-po master
>> >
>> > for you to fetch changes up to 21860882c8782771e99aa68fab6e365c628ff39d:
>> > l10n: fr.po: hotfix for commit 6b388fc (2013-08-30 16:59:29 +0800)
>> >
>> > ----------------------------------------------------------------
>> >
>> > Sebastien Helleu (1):
>> > l10n: fr.po: hotfix for commit 6b388fc
>>
>> Hmph, what happened that requires a "hotfix" to message strings?
>
> Well, as the author of the first commit,, I must say that the quality was not
> good. But it became visible and hooked up a reviewer only when it was promoted
> to stable version...
>
> There are some strings that do not make sense in the usage pages, a missing %s
> in one. Agreed that applying this patch does not solve a critical issue, but
> it is low risk.
OK, I was just reacting to the "hotfix" wording and wondering the
level of urgency. Will pull to maint later before cutting 1.8.4.1.
Thanks.
>
>>
>> > po/TEAMS | 1 +
>> > po/fr.po | 1591
>> > ++++++++++++++++++++++++++++++++++---------------------------- 2 files
>> > changed, 874 insertions(+), 718 deletions(-)
>> >
>> > --
>> > Jiang Xin
prev parent reply other threads:[~2013-08-30 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 9:07 [GIT PULL] hotfix on fr.po for the maint branch Jiang Xin
2013-08-30 16:54 ` Junio C Hamano
2013-08-30 17:23 ` Jean-Noël AVILA
2013-08-30 18:07 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqli3jyrw5.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=flashcode@flashtux.org \
--cc=git@vger.kernel.org \
--cc=jn.avila@free.fr \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox