Re: [PATCH 2/2] object-file: return error on index-pack abnormal exit

[Junio C Hamano <gitster@pobox.com>]

Kaartic Sivaraam <kaartic.sivaraam@gmail.com> writes:

>> Personally, I somehow find that the original "unless we positively
>> declare success, default to 'ret = -1', and if we may have detected
>> more specific error, return it back, and reset ret to 0 when we see
>> a success" easier to follow, but that may be subjective preference.
>
> +1. I too have a slight preference for the old flow of having ret = -1 
> and resetting it when there's no error. It may not be worth a re-roll, 
> though.

Note that my comment you quoted was made with a misunderstanding
of the patch and misses one important point, which is that
read_index_pack_report() used to overwrite "ret" even when it
succeeded, but the new code uses a separate variable to avoid
clobbering "ret" when the call succeeds.

In other words, the original failed to honor the "have ret = -1
and reset to 0 only after seeing everything go well" pattern,
either, and Justin's patch is a definite improvement.