Re: [PATCH v2] http: preserve wwwauth_headers across redirects

[Junio C Hamano <gitster@pobox.com>]

Jeff King <peff@peff.net> writes:

> On Mon, Nov 02, 2026 at 12:51:14AM -0800, Junio C Hamano wrote:
>
>> Junio C Hamano <gitster@pobox.com> writes:
>> 
>> > Junio C Hamano <gitster@pobox.com> writes:
>> >
>> >> For those of you who are watching from the sidelines, this v2 lacks
>> >> the threading history.
>> >>
>> >> The v1 is at https://lore.kernel.org/git/20260602161150.1527493-1-aplattner@nvidia.com/
>> >
>> > Any takers?  It should be quite easy to be more interested and be a
>> > better reviewer in the http transfer codepaths than I am.
>> 
>> Second call.  Anybody?
>> 
>> Unless we see some volunteers to give it a review in a few weeks, I
>> will discard the topic out of my tree, as 'seen' has been crowded
>> with topics that have been collecting dust without getting many
>> reviews.
>
> I gave it a review. In short, I think the patch is OK as-is, though I had a
> few small suggestions for the code (and it might be worth describing the
> "why is this safe" part in the commit message).
>
> I think one of the reasons it didn't get much review is that the wwwauth
> is not well understood by other folks who work on HTTP, and the original
> author of the feature wasn't cc'd (I did in my review, though he's not
> super active these days, so I also wouldn't hold my breath).

I see there were a few responses to your review.  Let's see how
Aaron responds---perhaps this time we see a small update to move it
beyond the finish line ;-).

Thanks.