From: Junio C Hamano <gitster@pobox.com>
To: Srujith Poojary <poojarysrujith@gmail.com>
Cc: Srujith A Poojary via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Phillip Wood <phillip.wood123@gmail.com>,
Usman Akinyemi <usmanakinyemi202@gmail.com>
Subject: Re: [PATCH v3] diff-delta: use safe integer arithmetic
Date: Sun, 25 Oct 2026 11:10:52 -0700 [thread overview]
Message-ID: <xmqqmrs1y7kj.fsf@gitster.g> (raw)
In-Reply-To: <CABh_KWhDcPM6rJROmVd7_oGZ7i3tmX5da-DZX=KJmvSyCxNH_A@mail.gmail.com> (Srujith Poojary's message of "Sat, 24 Oct 2026 22:56:08 +0530")
Srujith Poojary <poojarysrujith@gmail.com> writes:
> Thank you for the detailed correction.
>
> I have expanded the commit message to include the step-by-step
> breakdown for both the unpacked and packed index allocations,
> detailing the caps on hsize (2^26) and entries (2^28) alongside struct
> padding on 32-bit systems. I also corrected the phrasing regarding
> (hsize + 1) being passed as an argument to st_add3().
It seems that the text of v4 did not "detail" anything like that;
you just parroted the conclusion, the final numbers I gave you,
without giving any hint for the readers to validate the math. The
readers who are interested in validating are forced to figure out
how many bytes your calculation assumes each struct type involved
consume---and if they find that your conclusion is wrong, they have
no clue where in your computation things went wrong.
next prev parent reply other threads:[~2026-10-25 18:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 3:56 [PATCH] [Outreachy PATCH] diff-delta: use safe integer arithmetic Srujith A Poojary via GitGitGadget
2026-10-23 5:04 ` Junio C Hamano
2026-10-23 5:29 ` Srujith Poojary
2026-10-23 15:30 ` Junio C Hamano
2026-10-23 16:56 ` Srujith Poojary
2026-10-23 18:45 ` Junio C Hamano
2026-10-23 5:56 ` [PATCH v2] " Srujith A Poojary via GitGitGadget
2026-10-23 15:15 ` Phillip Wood
2026-10-23 18:49 ` Junio C Hamano
2026-10-24 3:44 ` Srujith Poojary
2026-10-24 3:48 ` [PATCH v3] " Srujith A Poojary via GitGitGadget
2026-10-24 16:15 ` Junio C Hamano
2026-10-24 17:26 ` Srujith Poojary
2026-10-25 18:10 ` Junio C Hamano [this message]
2026-10-25 19:21 ` Srujith Poojary
2026-10-24 18:00 ` [PATCH v4] " Srujith A Poojary via GitGitGadget
2026-10-25 19:20 ` [PATCH v5] " Srujith A Poojary via GitGitGadget
2026-10-26 17:37 ` Junio C Hamano
2026-10-26 18:47 ` Srujith Poojary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmrs1y7kj.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=phillip.wood123@gmail.com \
--cc=poojarysrujith@gmail.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox