Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Harald Nordgren <haraldnordgren@gmail.com>,
	 Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com>,
	 git@vger.kernel.org
Subject: Re: [PATCH] rebase: mention --abort alongside --continue
Date: Thu, 16 Jul 2026 10:24:18 -0700	[thread overview]
Message-ID: <xmqqmrvqhmpp.fsf@gitster.g> (raw)
In-Reply-To: <4d150f21-46ea-4bf7-b516-c1763c152b34@gmail.com> (Phillip Wood's message of "Thu, 16 Jul 2026 10:37:22 +0100")

Phillip Wood <phillip.wood123@gmail.com> writes:

> To me aborting a rebase because an exec command failed is almost never a 
> sensible route forward and we should not be encouraging users to abort 
> after a failed test - surely the sensible thing to do in that case is 
> fix the problem with "git commit --amend" and continue the rebase.

My conclusion, from my own experience with "git rebase", is the
same.

I wonder if the workflow that benefits from this "if exec fails,
give up and forget the whole thing" behavior is actually quite
different from what we consider the "normal" use of the command?
Perhaps the user is not interested in "rebasing" the history at
all, but is instead running a check on each and every commit.
That is, a more expensive version of:

        for commit in $(git rev-list bottom..top)
        do
                git reset --hard "$commit" &&
                do the exec command || break
        done

that just happens to be shorter to type?

      reply	other threads:[~2026-07-16 17:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-15 19:19 [PATCH] rebase: mention --abort alongside --continue Harald Nordgren via GitGitGadget
2026-06-16  8:36 ` Phillip Wood
2026-06-16 17:33   ` Junio C Hamano
2026-06-17  8:56     ` Harald Nordgren
2026-06-17  9:52     ` Phillip Wood
2026-06-17 12:19       ` Junio C Hamano
2026-06-18 18:49         ` Harald Nordgren
2026-06-19  1:36           ` Junio C Hamano
2026-07-16  6:02             ` Harald Nordgren
2026-07-16  9:37               ` Phillip Wood
2026-07-16 17:24                 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmrvqhmpp.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=haraldnordgren@gmail.com \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox