[PATCH] send-email: pass smtp hostname and port to Authen::SASL

[PATCH] send-email: pass smtp hostname and port to Authen::SASL

[Aditya Garg]

Starting from version 2.2000, Authen::SASL supports passing the SMTP
server hostname and port to the OAUTHBEARER string passed via SMTP AUTH.
Add support for the same in git-send-email.

Link: https://metacpan.org/pod/Authen::SASL::Perl::OAUTHBEARER

Signed-off-by: Aditya Garg <gargaditya08@live.com>
---
 git-send-email.perl | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/git-send-email.perl b/git-send-email.perl
index eed5420882..0ac4d634e8 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1474,6 +1474,8 @@ sub smtp_auth_maybe {
 						user     => $cred->{'username'},
 						pass     => $cred->{'password'},
 						authname => $cred->{'username'},
+						host     => $smtp_server,
+						(defined $smtp_server_port ? (port => $smtp_server_port) : ()),
 					}
 				);
 				$result = $smtp->auth($sasl);
-- 
2.52.0

Re: [PATCH] send-email: pass smtp hostname and port to Authen::SASL

[Junio C Hamano]

Aditya Garg <gargaditya08@live.com> writes:

[administrivia]

    Please do not send patch e-mails directly at me, unless you know
    that I am the area authority.  Initial submissions are better
    sent to the list on To: list, with area experts on Cc: if you
    know or found out who they are.

> Starting from version 2.2000, Authen::SASL supports passing the SMTP
> server hostname and port to the OAUTHBEARER string passed via SMTP AUTH.
> Add support for the same in git-send-email.

The proposed log message should answer these questions as well:

   What happens with version before 2.2000?  Is it safe to
   unconditionally add parameters like this patch does, and why?

> Link: https://metacpan.org/pod/Authen::SASL::Perl::OAUTHBEARER
>
> Signed-off-by: Aditya Garg <gargaditya08@live.com>
> ---
>  git-send-email.perl | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index eed5420882..0ac4d634e8 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1474,6 +1474,8 @@ sub smtp_auth_maybe {
>  						user     => $cred->{'username'},
>  						pass     => $cred->{'password'},
>  						authname => $cred->{'username'},
> +						host     => $smtp_server,
> +						(defined $smtp_server_port ? (port => $smtp_server_port) : ()),
>  					}
>  				);
>  				$result = $smtp->auth($sasl);

Thanks.

Re: [PATCH] send-email: pass smtp hostname and port to Authen::SASL

[Aditya Garg]

> On 5 Mar 2026, at 8:15 PM, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Aditya Garg <gargaditya08@live.com> writes:
> 
> [administrivia]
> 
>    Please do not send patch e-mails directly at me, unless you know
>    that I am the area authority.  Initial submissions are better
>    sent to the list on To: list, with area experts on Cc: if you
>    know or found out who they are.

Oh sorry. I just did whatever I did in my previous contributions. I didn't know the rules changed.

Will mail just the mailing list next time.

> 
>> Starting from version 2.2000, Authen::SASL supports passing the SMTP
>> server hostname and port to the OAUTHBEARER string passed via SMTP AUTH.
>> Add support for the same in git-send-email.
> 
> The proposed log message should answer these questions as well:
> 
>   What happens with version before 2.2000?  Is it safe to
>   unconditionally add parameters like this patch does, and why?

It's safe to add parameters unconditionally because the library will simply reject them without any error. It's basically like declaring a variable and not using it anywhere for older versions. I have tested this with old libraries as well.

Consider the fact that the authname variable is also not in every authentication method used by Authen SASL, still its declared unconditionally before.

> 
>> Link: https://metacpan.org/pod/Authen::SASL::Perl::OAUTHBEARER
>> 
>> Signed-off-by: Aditya Garg <gargaditya08@live.com>
>> ---
>> git-send-email.perl | 2 ++
>> 1 file changed, 2 insertions(+)
>> 
>> diff --git a/git-send-email.perl b/git-send-email.perl
>> index eed5420882..0ac4d634e8 100755
>> --- a/git-send-email.perl
>> +++ b/git-send-email.perl
>> @@ -1474,6 +1474,8 @@ sub smtp_auth_maybe {
>>                        user     => $cred->{'username'},
>>                        pass     => $cred->{'password'},
>>                        authname => $cred->{'username'},
>> +                        host     => $smtp_server,
>> +                        (defined $smtp_server_port ? (port => $smtp_server_port) : ()),
>>                    }
>>                );
>>                $result = $smtp->auth($sasl);
> 
> Thanks.

Re: [PATCH] send-email: pass smtp hostname and port to Authen::SASL

[Junio C Hamano]

Aditya Garg <gargaditya08@live.com> writes:

>> On 5 Mar 2026, at 8:15 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> 
>> Aditya Garg <gargaditya08@live.com> writes:
>> 
>> [administrivia]
>> 
>>    Please do not send patch e-mails directly at me, unless you know
>>    that I am the area authority.  Initial submissions are better
>>    sent to the list on To: list, with area experts on Cc: if you
>>    know or found out who they are.
>
> Oh sorry. I just did whatever I did in my previous contributions. I didn't know the rules changed.

No rule changes as far as I know.

>>> Starting from version 2.2000, Authen::SASL supports passing the SMTP
>>> server hostname and port to the OAUTHBEARER string passed via SMTP AUTH.
>>> Add support for the same in git-send-email.
>> 
>> The proposed log message should answer these questions as well:
>> 
>>   What happens with version before 2.2000?  Is it safe to
>>   unconditionally add parameters like this patch does, and why?
>
> It's safe to add parameters unconditionally because the library
> will simply reject them without any error. It's basically like
> declaring a variable and not using it anywhere for older
> versions. I have tested this with old libraries as well.
>
> Consider the fact that the authname variable is also not in every
> authentication method used by Authen SASL, still its declared
> unconditionally before.

These are good to have in the proposed log message.

Thanks.

Re: [PATCH] send-email: pass smtp hostname and port to Authen::SASL

[Aditya Garg]

On 05/03/26 9:54 pm, Junio C Hamano wrote:
> Aditya Garg <gargaditya08@live.com> writes:
> 
>>> On 5 Mar 2026, at 8:15 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>>
>>> Aditya Garg <gargaditya08@live.com> writes:
>>>
>>> [administrivia]
>>>
>>>    Please do not send patch e-mails directly at me, unless you know
>>>    that I am the area authority.  Initial submissions are better
>>>    sent to the list on To: list, with area experts on Cc: if you
>>>    know or found out who they are.
>>
>> Oh sorry. I just did whatever I did in my previous contributions. I didn't know the rules changed.
> 
> No rule changes as far as I know.

I had sent several patches for send-email and imap-send between 2.50 and 2.52, and in every submission I did email directly to the maintainers. Maybe you were just lenient with me that time. Regardless, I'll make sure that future patches are sent only to the mailing list.

> 
>>>> Starting from version 2.2000, Authen::SASL supports passing the SMTP
>>>> server hostname and port to the OAUTHBEARER string passed via SMTP AUTH.
>>>> Add support for the same in git-send-email.
>>>
>>> The proposed log message should answer these questions as well:
>>>
>>>   What happens with version before 2.2000?  Is it safe to
>>>   unconditionally add parameters like this patch does, and why?
>>
>> It's safe to add parameters unconditionally because the library
>> will simply reject them without any error. It's basically like
>> declaring a variable and not using it anywhere for older
>> versions. I have tested this with old libraries as well.
>>
>> Consider the fact that the authname variable is also not in every
>> authentication method used by Authen SASL, still its declared
>> unconditionally before.
> 
> These are good to have in the proposed log message.

Will send a v2

Cheers!

[PATCH v2] send-email: pass smtp hostname and port to Authen::SASL

[Aditya Garg]

Starting from version 2.2000, Authen::SASL supports passing the SMTP
server hostname and port to the OAUTHBEARER string passed via SMTP AUTH.
Add support for the same in git-send-email.

It's safe to add the new parameters unconditionally as older versions of
Authen::SASL will simply ignore them without any error. Something
similar is already being done for the authname parameter, which is not
supported by every authentication mechanism. This can be understood as
declaring a variable but not using at all.

Link: https://metacpan.org/pod/Authen::SASL::Perl::OAUTHBEARER

Signed-off-by: Aditya Garg <gargaditya08@live.com>
---
 git-send-email.perl | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/git-send-email.perl b/git-send-email.perl
index eed5420882..0ac4d634e8 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1474,6 +1474,8 @@ sub smtp_auth_maybe {
 						user     => $cred->{'username'},
 						pass     => $cred->{'password'},
 						authname => $cred->{'username'},
+						host     => $smtp_server,
+						(defined $smtp_server_port ? (port => $smtp_server_port) : ()),
 					}
 				);
 				$result = $smtp->auth($sasl);

Range-diff against v1:
1:  9b48ca57ae ! 1:  5befaa626d send-email: pass smtp hostname and port to Authen::SASL
    @@ Commit message
         server hostname and port to the OAUTHBEARER string passed via SMTP AUTH.
         Add support for the same in git-send-email.
     
    +    It's safe to add the new parameters unconditionally as older versions of
    +    Authen::SASL will simply ignore them without any error. Something
    +    similar is already being done for the authname parameter, which is not
    +    supported by every authentication mechanism. This can be understood as
    +    declaring a variable but not using at all.
    +
         Link: https://metacpan.org/pod/Authen::SASL::Perl::OAUTHBEARER
     
         Signed-off-by: Aditya Garg <gargaditya08@live.com>
-- 
2.52.0