From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Nasser Grainawi <nasser.grainawi@oss.qualcomm.com>,
git@vger.kernel.org, "D. Ben Knoble" <ben.knoble@gmail.com>,
Patrick Steinhardt <ps@pks.im>,
Jacob Keller <jacob.keller@gmail.com>
Subject: Re: [PATCH v5] submodule: fetch missing objects from default remote
Date: Tue, 03 Mar 2026 13:26:07 -0800 [thread overview]
Message-ID: <xmqqms0obo5s.fsf@gitster.g> (raw)
In-Reply-To: <2e62dc94-b821-4815-8dd2-f806580d2027@ramsayjones.plus.com> (Ramsay Jones's message of "Tue, 3 Mar 2026 20:47:02 +0000")
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> + diff -u expect_fetch_custom actual_fetch_warnings_removed
> --- expect_fetch_custom 2026-03-03 20:35:13.949600802 +0000
> +++ actual_fetch_warnings_removed 2026-03-03 20:35:14.150601532 +0000
> @@ -4,9 +4,9 @@
> Fetching submodule sub1/subdir/deepsubmodule
> Fetching submodule submodule
> Fetching submodule submodule/subdir/deepsubmodule
> -From /home/ramsay/git/t/trash directory.t5526-fetch-submodules.stress-5/./sub1
> - * branch 43c17d99ab9d4fcabf7107e36660b27113b54663 -> FETCH_HEAD
> -Fetching submodule sub1/subdir/deepsubmodule
> From /home/ramsay/git/t/trash directory.t5526-fetch-submodules.stress-5/submodule
> * branch e38933e027ee8a2000f603124aa899302a09a51f -> FETCH_HEAD
> Fetching submodule submodule/subdir/deepsubmodule
> +From /home/ramsay/git/t/trash directory.t5526-fetch-submodules.stress-5/./sub1
> + * branch 43c17d99ab9d4fcabf7107e36660b27113b54663 -> FETCH_HEAD
> +Fetching submodule sub1/subdir/deepsubmodule
> error: last command exited with $?=1
> not ok 44 - fetch new submodule commits on-demand outside standard refspec with custom remote name
>
> ...
>
> $
>
> From which I guess that the order of the output is somewhat unpredictable.
>
> Also, other test files in that patch didn't fail for me with 'make test', but it
> could be possible that they are also flaky. I didn't look.
Ah, looks like the command tries to fetch from multiple places in
parallel and it is up to the luck which one reports its result
first? We probably do not want such a "human readable progress
output should look exactly like this" test.
Thanks for reporting.
next prev parent reply other threads:[~2026-03-03 21:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 21:36 [PATCH] Fetch missing submodule objects from default remote Nasser Grainawi
2026-01-13 2:17 ` Jacob Keller
2026-01-13 21:51 ` Ben Knoble
2026-01-13 22:41 ` Nasser Grainawi
2026-01-14 2:19 ` D. Ben Knoble
2026-01-14 14:10 ` Junio C Hamano
2026-01-14 21:22 ` Ben Knoble
2026-01-14 14:05 ` Junio C Hamano
2026-01-14 19:23 ` Nasser Grainawi
2026-01-14 19:48 ` [PATCH v2] submodule: fetch missing " Nasser Grainawi
2026-01-21 0:48 ` Nasser Grainawi
2026-01-22 15:27 ` [PATCH v3] " Nasser Grainawi
2026-01-22 18:49 ` Junio C Hamano
2026-01-22 20:16 ` Jacob Keller
2026-01-22 20:38 ` Junio C Hamano
2026-02-25 21:55 ` Junio C Hamano
2026-03-02 22:06 ` Jacob Keller
2026-02-27 18:29 ` Nasser Grainawi
2026-01-22 21:21 ` Junio C Hamano
2026-01-23 23:26 ` Junio C Hamano
2026-01-24 2:18 ` Junio C Hamano
2026-02-20 23:12 ` Junio C Hamano
2026-02-27 17:20 ` Nasser Grainawi
2026-03-01 2:53 ` [PATCH v4] " Nasser Grainawi
2026-03-02 22:09 ` Jacob Keller
2026-03-02 22:11 ` Junio C Hamano
2026-03-03 2:11 ` Junio C Hamano
2026-03-03 19:00 ` Nasser Grainawi
2026-03-03 19:26 ` Nasser Grainawi
2026-03-03 20:02 ` Junio C Hamano
2026-03-03 20:09 ` [PATCH v5] " Nasser Grainawi
2026-03-03 20:47 ` Ramsay Jones
2026-03-03 21:26 ` Junio C Hamano [this message]
2026-03-03 23:29 ` Nasser Grainawi
2026-03-03 23:40 ` [PATCH v6] " Nasser Grainawi
2026-03-09 23:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqms0obo5s.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=jacob.keller@gmail.com \
--cc=nasser.grainawi@oss.qualcomm.com \
--cc=ps@pks.im \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox