From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a2-smtp.messagingengine.com (fout-a2-smtp.messagingengine.com [103.168.172.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C96BB282F25 for ; Mon, 2 Mar 2026 22:11:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.145 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772489498; cv=none; b=MZPlStoav2FnmAzGR7FftJZkDDKdN47opgbP0AFPbWi55F3afJuZcT1JSuPeBKWW96FjEkowm1G+x86rEw6xopiD//k1W3ieZJlUtuOE3Yj3LjvDcn1p6tpiPRWoWEnuCZW5hv7Ap3qbjOy55+blxchctM+Q44O0wZUMEX+GZts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772489498; c=relaxed/simple; bh=ZbyaCuYcs5o+5ZQi1wALc8Frw/KdH1ipRCvO5rP+ccY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=efmQhGrZQYbYfKe5M68NADNfyhk4GKt3dOpJUOCF+9Jq7h9NWzA2Rw0xdJIZQ/Rj2I7+iimU3HIR7LlhqTk7tyzYQX+u7Xgt2QCVU2QwOZHZL9CEv+YOP6xc2+4rs++wF4codEIxLp3sXkjAelZmYROPYB5aCsLIVIeuu6oIpn4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b=jHp/MQgS; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=TDePwid1; arc=none smtp.client-ip=103.168.172.145 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b="jHp/MQgS"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="TDePwid1" Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 1A1BAEC0350; Mon, 2 Mar 2026 17:11:37 -0500 (EST) Received: from phl-frontend-02 ([10.202.2.161]) by phl-compute-05.internal (MEProxy); Mon, 02 Mar 2026 17:11:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1772489497; x=1772575897; bh=+856K2TcNW HeCwHOOW424DsI2V2c++BqDXCEvVNLL7k=; b=jHp/MQgSNwD0rsTZ4TIWbH+74y gm0rDFHa0OEZZvagK8t30UM6ysBnKXc0nWY3i/jKTJDl0otY5JjmFSbZdwGDGd3e m4Fsi6GNjYvX2FVnrpme7LIkk2V/8O/gSGM+4ozIXFIJw9RPYSBK+tjx349odg2q 4D0He0OFDjDqxIIU66HSZBJzgwFp5ejTQeQ0i3fA1Z1sX3WjUOq6cv7QZewuMUNW 3ARUpmVvOH77YEkSK1JBgWiYCJiF86+5ujgEqMr5PvfwjNFmXwYA2BZRylbP9TWV NB49KzYBs4muaE6fFReu1GcPb8ltpQqW1VOVdT0m7ntpgr50YxoUY4qzjpag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1772489497; x=1772575897; bh=+856K2TcNWHeCwHOOW424DsI2V2c++BqDXC EvVNLL7k=; b=TDePwid12lqPvgWctp+YG05SPcHLEdwa62mweYiwjF3WWbURMS9 GXr5naFTe+NEiRdN60fHmm40vvZUuT/j/xFlsVxD97N+Ui/x4QWeC07UjC5N4YGE A9hdU/4jQSkfIifU/EdiiCF/irlWQX5oiio9QK0hwQovIsZHavRpWc5sDDVSTOCG dw/9AHgsZnZm3Ah6fRXcbHBXH50UB5701t56ILdkShMQCLuu+udvKXXp6qL5ughm AX18QbeZG9bo/shFn7e89x5hlieXAxanzIjtbN1bDmHotUKJKu5u2YkrZ6u/wSzb ue+IkFo5JlLZzoGk6IWkGGUFJe7eBRbqFmQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvheekkeehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefujghffffkfgggtgesthdtredttdertdenucfhrhhomheplfhunhhiohcu vecujfgrmhgrnhhouceoghhithhsthgvrhesphhosghogidrtghomheqnecuggftrfgrth htvghrnhepfeevteetjeehueegffelvdetieevffeufeejleeuffetiefggfeftdfhfeei geeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepgh hithhsthgvrhesphhosghogidrtghomhdpnhgspghrtghpthhtohepiedpmhhouggvpehs mhhtphhouhhtpdhrtghpthhtohepjhgrtghosgdrkhgvlhhlvghrsehgmhgrihhlrdgtoh hmpdhrtghpthhtohepnhgrshhsvghrrdhgrhgrihhnrgifihesohhsshdrqhhurghltgho mhhmrdgtohhmpdhrtghpthhtohepghhithesvhhgvghrrdhkvghrnhgvlhdrohhrghdprh gtphhtthhopegsvghnrdhknhhosghlvgesghhmrghilhdrtghomhdprhgtphhtthhopehp shesphhkshdrihhmpdhrtghpthhtohepghhithhsthgvrhesphhosghogidrtghomh X-ME-Proxy: Feedback-ID: if26b431b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 2 Mar 2026 17:11:36 -0500 (EST) From: Junio C Hamano To: Jacob Keller Cc: Nasser Grainawi , git@vger.kernel.org, "D. Ben Knoble" , Patrick Steinhardt Subject: Re: [PATCH v4] submodule: fetch missing objects from default remote In-Reply-To: (Jacob Keller's message of "Mon, 2 Mar 2026 14:09:18 -0800") References: <20260122152722.866341-1-nasser.grainawi@oss.qualcomm.com> <20260301025327.3845292-1-nasser.grainawi@oss.qualcomm.com> Date: Mon, 02 Mar 2026 14:11:35 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Jacob Keller writes: >> v4 includes fixes for the issues Junio patched in seen and I confirmed >> it merges cleanly to seen (with v3 reverted) as well as next and passes >> tests. >> > > v4 looks good, thanks! > > Reviewed-by: Jacob Keller Thanks. Will wiggle your Reviewed-by in while queuing the patch.