From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
Elijah Newren <newren@gmail.com>, Jeff King <peff@peff.net>,
"brian m . carlson" <sandals@crustytoothpaste.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH 3/3] fast-import: add 'strip-if-invalid' mode to --signed-commits=<mode>
Date: Wed, 12 Nov 2025 08:51:32 -0800 [thread overview]
Message-ID: <xmqqms4rry7f.fsf@gitster.g> (raw)
In-Reply-To: <CAP8UFD3G6kn-n1_rXJgcZf1djUE4Ner5xd1YaNr5tz5h8d_Ypw@mail.gmail.com> (Christian Couder's message of "Wed, 12 Nov 2025 08:25:20 +0100")
Christian Couder <christian.couder@gmail.com> writes:
> On Sat, Nov 8, 2025 at 7:32 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Christian Couder <christian.couder@gmail.com> writes:
>>
>> > t/t9305-fast-import-signatures.sh | 118 ++++++++++++++++++++++++++++-
>> > 6 files changed, 226 insertions(+), 28 deletions(-)
>>
>> Unfortunately all these tests that assume that explicit-sha256
>> repository as a subdirectory exists would fail when the topic is
>> merged to 'seen' and the tree is built without the optional Rust
>> support. This is because brian's f6581e23 (repository: require Rust
>> support for interoperability, 2025-10-27) changes a couple of tests
>> to require RUST prerequisite. One of them is what creates the
>> explicit-sha256 repository.
>>
>> I do not think this topic to preserve or strip GPG signatures
>> particularly cares about the dual hash interoperability, so can you
>> rearrange the tests in this series to avoid crashing with the other
>> topic?
>
> I will do that in the v2 I hope I can send soon.
Thanks.
next prev parent reply other threads:[~2025-11-12 16:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 6:19 [PATCH 0/3] fast-import: add 'strip-if-invalid' mode to --signed-commits=<mode> Christian Couder
2025-11-05 6:19 ` [PATCH 1/3] fast-import: refactor finalize_commit_buffer() Christian Couder
2025-11-05 6:19 ` [PATCH 2/3] commit: refactor verify_commit_buffer() Christian Couder
2025-11-05 6:19 ` [PATCH 3/3] fast-import: add 'strip-if-invalid' mode to --signed-commits=<mode> Christian Couder
2025-11-08 18:32 ` Junio C Hamano
2025-11-12 7:25 ` Christian Couder
2025-11-12 16:51 ` Junio C Hamano [this message]
2025-11-05 14:40 ` [PATCH 0/3] " Junio C Hamano
2025-11-08 0:34 ` Elijah Newren
2025-11-12 7:22 ` Christian Couder
2025-11-12 7:19 ` Christian Couder
2025-11-12 16:51 ` Junio C Hamano
2025-11-17 4:34 ` [PATCH v2 " Christian Couder
2025-11-17 4:34 ` [PATCH v2 1/3] fast-import: refactor finalize_commit_buffer() Christian Couder
2025-11-17 4:34 ` [PATCH v2 2/3] commit: refactor verify_commit_buffer() Christian Couder
2025-11-17 4:34 ` [PATCH v2 3/3] fast-import: add 'strip-if-invalid' mode to --signed-commits=<mode> Christian Couder
2025-11-17 19:52 ` [PATCH v2 0/3] " Elijah Newren
2025-11-18 18:29 ` Christian Couder
2025-11-18 19:03 ` Junio C Hamano
2025-11-18 19:04 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqms4rry7f.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).