From: Junio C Hamano <gitster@pobox.com>
To: "Kristoffer Haugsbakk" <code@khaugsbakk.name>
Cc: "Josh Soref" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Knut Harald Ryager" <e-k-nut@hotmail.com>
Subject: Re: [PATCH v2] Remove the extra and incorrect closing bracket, so that the line reads:
Date: Mon, 11 Aug 2025 09:07:57 -0700 [thread overview]
Message-ID: <xmqqms853kpu.fsf@gitster.g> (raw)
In-Reply-To: <a065e0cb-75e6-4836-9897-05089089367c@app.fastmail.com> (Kristoffer Haugsbakk's message of "Mon, 11 Aug 2025 08:14:06 +0200")
"Kristoffer Haugsbakk" <code@khaugsbakk.name> writes:
> I think you want this:
>
> docs: remove stray bracket from git-clone synopsis
>
> Remove the extra and incorrect closing bracket, so that the line
> reads:
>
> [--filter=<filter> [--also-filter-submodules]]
>
> instead of
>
> [--filter=<filter>] [--also-filter-submodules]]
As even the author of this patch was once confused, I think
the reason why this plausible change
[--filter=<filter>] [--also-filter-submodules]
is not a correct fix should also be in the proposed log message to
help readers.
next prev parent reply other threads:[~2025-08-11 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 14:46 [PATCH] docs: remove stray bracket from git-clone synopsis Knut Harald Ryager via GitGitGadget
2025-07-31 19:07 ` Junio C Hamano
2025-08-10 21:30 ` [PATCH v2] Remove the extra and incorrect closing bracket, so that the line reads: Knut Harald Ryager via GitGitGadget
2025-08-11 6:14 ` Kristoffer Haugsbakk
2025-08-11 16:07 ` Junio C Hamano [this message]
2025-08-11 22:04 ` [PATCH v3] docs: remove stray bracket from git-clone synopsis Knut Harald Ryager via GitGitGadget
2025-08-12 15:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqms853kpu.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=code@khaugsbakk.name \
--cc=e-k-nut@hotmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).