From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Jonas Brandstötter" <jonas.brandstoetter@gmx.at>, git@vger.kernel.org
Subject: Re: [PATCH v2 2/2] t7510: add test cases for non-absolute gpg program
Date: Tue, 29 Jul 2025 08:06:04 -0700 [thread overview]
Message-ID: <xmqqms8nqboj.fsf@gitster.g> (raw)
In-Reply-To: <20250729071247.GA1426859@coredump.intra.peff.net> (Jeff King's message of "Tue, 29 Jul 2025 03:12:47 -0400")
Jeff King <peff@peff.net> writes:
> On Mon, Jul 28, 2025 at 05:05:46PM -0700, Junio C Hamano wrote:
>
>> > Should it be "/d/a/git/git/..." instead of "D:/a/git/git/..."? Which we
>> > could get by using $PWD, I think.
>> >
>> > The earlier one using $HOME uses D:/, but this one is different because
>> > colons are meaningful separators in $PATH.
>>
>> Here is what I have on top of the posted patches. If today's
>> integration goes well, I plan to merge it to 'next'; the rest of the
>> series is already in 'next'.
>
> Looks good. Not sure if you saw the patch I posted in this thread. It's
> roughly the same as yours, though I didn't drop the useless "env" (which
> I agree is useless).
Ah, sorry, no I missed it. Will replace with your variant.
> I did reference 71dd50472d (t0021, t5615: use $PWD instead of $(pwd) in
> PATH-like shell variables, 2016-11-11) to try to give more explanation
> of the two different sources. But re-reading it, it actually doesn't
> really clarify much. ;) So maybe not worth worrying about.
>
> -Peff
Thanks.
next prev parent reply other threads:[~2025-07-29 15:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 15:04 [BUG] gpg.program: '~' not expanded to home directory Ross MacArthur
2025-07-11 23:23 ` [PATCH] gpg-interface: expand gpg.program as a path Jonas Brandstötter
2025-07-14 17:10 ` Junio C Hamano
2025-07-22 19:09 ` [PATCH v2 0/2] " Jonas Brandstötter
2025-07-22 20:28 ` Junio C Hamano
2025-07-22 19:09 ` [PATCH v2 1/2] " Jonas Brandstötter
2025-07-22 19:09 ` [PATCH v2 2/2] t7510: add test cases for non-absolute gpg program Jonas Brandstötter
2025-07-25 4:30 ` Jeff King
2025-07-25 5:13 ` Jeff King
2025-07-29 0:05 ` Junio C Hamano
2025-07-29 7:12 ` Jeff King
2025-07-29 15:06 ` Junio C Hamano [this message]
2025-07-12 0:05 ` [BUG] gpg.program: '~' not expanded to home directory Junio C Hamano
2025-07-12 9:38 ` Andreas Schwab
2025-07-12 14:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqms8nqboj.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonas.brandstoetter@gmx.at \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).