git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ghanshyam Thakkar" <shyamthakkar001@gmail.com>
Cc: "Meet Soni" <meetsoni3017@gmail.com>,  <git@vger.kernel.org>,
	<christian.couder@gmail.com>,  <karthik.188@gmail.com>,
	<kaartic.sivaraam@gmail.com>,  <ps@pks.im>,
	 <shejialuo@gmail.com>, <chandrapratap3519@gmail.com>
Subject: Re: [PATCH v3] t7611: replace test -f with test_path_is* helpers
Date: Fri, 27 Dec 2024 08:15:35 -0800	[thread overview]
Message-ID: <xmqqmsght848.fsf@gitster.g> (raw)
In-Reply-To: <D6MH7E17E6I0.3IG5103E7XXP3@gmail.com> (Ghanshyam Thakkar's message of "Fri, 27 Dec 2024 17:49:17 +0530")

"Ghanshyam Thakkar" <shyamthakkar001@gmail.com> writes:

> On Fri Dec 27, 2024 at 4:23 PM IST, Meet Soni wrote:
>> Replace `test -f` and `test ! -f` with `test_path_is_file` and
>> `test_path_is_missing` for better debuggability.
>>
>> While `test -f` ensures that the file exists and is a regular file,
>> `test_path_is_file` provides clearer error messages on failure. On the
>> other hand, `test ! -f`, used to check either the absence of a regular
>> file or the presence of any other filesystem object, but looking at
>> them in the test individually, all of them should've said `test ! e`,
>> i.e. "there shouldn't be anything at given path on filesystem."
>> Replaced these cases with `test_path_is_missing` for better
>> debuggability.
>
> 'Replaced' -> 'Replace'. Cf. https://git-scm.com/docs/SubmittingPatches#imperative-mood
>
> Other than that, this LGTM.

Thanks, both.  Tweaked the log message before applying.  No need to
resend.

Queued.

      reply	other threads:[~2024-12-27 16:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-18 11:17 [GSoC] [PATCH] t7611: replace test -f with test_path_is* helpers Meet Soni
2024-12-18 15:23 ` karthik nayak
2024-12-20 13:06 ` [PATCH v2] " Meet Soni
2024-12-20 14:16   ` Junio C Hamano
2024-12-27 10:53   ` [PATCH v3] " Meet Soni
2024-12-27 12:19     ` Ghanshyam Thakkar
2024-12-27 16:15       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmsght848.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=chandrapratap3519@gmail.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=karthik.188@gmail.com \
    --cc=meetsoni3017@gmail.com \
    --cc=ps@pks.im \
    --cc=shejialuo@gmail.com \
    --cc=shyamthakkar001@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).