git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Sören Krecker" <soekkle@freenet.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/4] Fixes typemissmatch warinigs from msvc
Date: Mon, 23 Dec 2024 08:37:21 -0800	[thread overview]
Message-ID: <xmqqmsgm1hku.fsf@gitster.g> (raw)
In-Reply-To: <20241223110407.3308-1-soekkle@freenet.de> ("Sören Krecker"'s message of "Mon, 23 Dec 2024 12:04:03 +0100")

Sören Krecker <soekkle@freenet.de> writes:

> A smale series of patches to fix some typemissmatch warings from msvc 14.30.
> Most of the missmatches a 64 to 32 bit conversion on a 64 bit Windows platform.

Thanks for the patches.

I'll welcome other people to take a look, if they are inclined, but
it is not something I'd want to look at during a pre-release freeze.
Nobody sane would be running "git add -p" on a patch that exceeds
2GB, for example, so the only practical thing they fix are compiler
warnings.  They are worth fixing eventually, but not all that
urgent.

Thanks, again.

  parent reply	other threads:[~2024-12-23 16:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-23 11:04 [PATCH 0/4] Fixes typemissmatch warinigs from msvc Sören Krecker
2024-12-23 11:04 ` [PATCH 1/4] add-patch: Fix type missmatch rom msvc Sören Krecker
2024-12-26 21:33   ` Junio C Hamano
2024-12-27 10:16     ` Patrick Steinhardt
2024-12-27 10:38     ` Phillip Wood
2024-12-27 14:31       ` Junio C Hamano
2024-12-27 16:35         ` Sören Krecker
2024-12-27 16:42           ` Junio C Hamano
2024-12-28 16:04         ` Phillip Wood
2024-12-23 11:04 ` [PATCH 2/4] date.c: Fix type missmatch warings from msvc Sören Krecker
2024-12-26 21:34   ` Junio C Hamano
2024-12-23 11:04 ` [PATCH 3/4] apply.c : " Sören Krecker
2024-12-23 11:04 ` [PATCH 4/4] commit.c: " Sören Krecker
2024-12-26 21:38   ` Junio C Hamano
2024-12-23 16:37 ` Junio C Hamano [this message]
2024-12-23 16:52   ` [PATCH 0/4] Fixes typemissmatch warinigs " Junio C Hamano
2024-12-26  8:59     ` Sören Krecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmsgm1hku.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=soekkle@freenet.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).