git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,  Shubham Kanodia <shubham.kanodia10@gmail.com>
Subject: Re: [PATCH] builtin/gc: fix crash when running `git maintenance start`
Date: Wed, 09 Oct 2024 16:14:38 -0700	[thread overview]
Message-ID: <xmqqmsjcoom9.fsf@gitster.g> (raw)
In-Reply-To: <xmqqbjzu1m2j.fsf@gitster.g> (Junio C. Hamano's message of "Tue, 08 Oct 2024 11:33:40 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Patrick Steinhardt <ps@pks.im> writes:
>
>> Fix the regression by again unconditionally allocating the value in the
>> `out` parameter, if provided. Add a test that unsets the environment
>> variable to catch future regressions in this area.
>>
>> Reported-by: Shubham Kanodia <shubham.kanodia10@gmail.com>
>> Signed-off-by: Patrick Steinhardt <ps@pks.im>
>> ---
>
> Thanks for quickly reporting and addressing this one, both of you.
>
> Will queue.

We seem to be getting:

  git maintenance start --scheduler=systemd
  D:/a/git/git/git.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory

https://github.com/git/git/actions/runs/11264159690/job/31323795058#step:5:327


  reply	other threads:[~2024-10-09 23:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-08 10:50 Bug: `git maintenance start` is likely broken in 2.47 Shubham Kanodia
2024-10-08 11:45 ` Patrick Steinhardt
2024-10-08 12:15 ` [PATCH] builtin/gc: fix crash when running `git maintenance start` Patrick Steinhardt
2024-10-08 18:30   ` Derrick Stolee
2024-10-09  2:58     ` Derrick Stolee
2024-10-09  6:28       ` Patrick Steinhardt
2024-10-08 18:33   ` Junio C Hamano
2024-10-09 23:14     ` Junio C Hamano [this message]
2024-10-10  4:54       ` Patrick Steinhardt
2024-10-10  5:10         ` Patrick Steinhardt
2024-10-09  7:08 ` [PATCH v2] " Patrick Steinhardt
2024-10-09 13:13   ` Derrick Stolee
2024-10-09 17:28     ` Junio C Hamano
2024-10-09 17:10   ` Junio C Hamano
2024-10-10  5:33 ` [PATCH v3] " Patrick Steinhardt
2024-10-10 17:09   ` Junio C Hamano
2024-10-14  4:44     ` Shubham Kanodia
2024-10-14  8:38       ` Patrick Steinhardt
2024-10-15  0:36         ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmsjcoom9.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    --cc=shubham.kanodia10@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).