From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Samuel Abraham <abrahamadekunle50@gmail.com>,
Samuel Adekunle Abraham via GitGitGadget
<gitgitgadget@gmail.com>,
git@vger.kernel.org, phillip.wood@dunelm.org.uk,
christian.couder@gmail.com
Subject: Re: [PATCH] t7300-clean.sh: use test_path_* helper functions
Date: Wed, 09 Oct 2024 10:31:35 -0700 [thread overview]
Message-ID: <xmqqmsjduqrs.fsf@gitster.g> (raw)
In-Reply-To: <ZwYux_Nb9GwqPuuk@pks.im> (Patrick Steinhardt's message of "Wed, 9 Oct 2024 09:20:45 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> I think that your v2 isn't quite there yet. As Junio mentions, he'd like
> to see an updated commit message that includes your explanations why you
> have done certain conversions the way you did. The fact that some parts
> of the patch required discussion to arrive at a common understanding is
> a good telling factor that a summarized form of the discussion should
> likely be part of the commit message such that future readers of the
> patch will get the same context.
What v2 had after the three-dash line seemed to me an OK material
for a proposed commit log message, but it should have been before
the line. I suspect that it was from typical GGG gotcha?
Thanks.
next prev parent reply other threads:[~2024-10-09 17:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 19:19 [PATCH] t7300-clean.sh: use test_path_* helper functions Samuel Adekunle Abraham via GitGitGadget
2024-10-07 23:01 ` Usman Akinyemi
2024-10-08 1:48 ` Junio C Hamano
2024-10-08 5:12 ` Samuel Abraham
2024-10-08 8:58 ` Samuel Abraham
2024-10-08 18:13 ` Junio C Hamano
2024-10-09 3:35 ` Samuel Abraham
2024-10-09 7:20 ` Patrick Steinhardt
2024-10-09 15:41 ` Samuel Abraham
2024-10-09 17:31 ` Junio C Hamano [this message]
2024-10-08 12:22 ` [PATCH v2] t7300-clean.sh: use test_path_* helper functions for error logging Samuel Adekunle Abraham via GitGitGadget
2024-10-09 17:02 ` [PATCH v3] " Samuel Adekunle Abraham via GitGitGadget
2024-10-09 17:47 ` Junio C Hamano
2024-10-09 18:24 ` Samuel Abraham
2024-10-09 18:22 ` [PATCH v4] " Samuel Adekunle Abraham via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmsjduqrs.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=abrahamadekunle50@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).