From: Junio C Hamano <gitster@pobox.com>
To: Stefan Haller <lists@haller-berlin.de>
Cc: git@vger.kernel.org
Subject: Re: Thoughts on the "branch <b> is not fully merged" error of "git-branch -d"
Date: Sat, 07 Sep 2024 13:00:52 -0700 [thread overview]
Message-ID: <xmqqmskjw7wr.fsf@gitster.g> (raw)
In-Reply-To: <d97a69bc-85f0-46e3-8c99-0e5556ffdc9a@haller-berlin.de> (Stefan Haller's message of "Sat, 7 Sep 2024 20:51:42 +0200")
Stefan Haller <lists@haller-berlin.de> writes:
>> Having said all that, I do not mind if somebody wanted to further
>> extend builtin/branch.c:branch_merged() so that users can explicitly
>> configure a set of reference branches. "The 'master' and 'maint'
>> are the integration branches that are used in this repository.
>> Unless the history of a local branch is fully merged to one of
>> these, 'git branch -d' of such a local branch will stop." may be a
>> reasonable thing to do.
>
> This makes sense to me (if you include the upstreams of master and maint
> in that logic, because the local ones might not be up to date).
I get the idea behind that statement, but I do not think it is
necessary to make Git second guess the end user is warranted in this
case.
If refs/heads/master builds on top of refs/remotes/origin/master,
and if the user is worried about the former being not up to date
relative to the latter, then the user can say "'branch -d' is safe
if the commit is merged in refs/remotes/origin/master", instead of
telling the command to check with 'refs/heads/master'.
next prev parent reply other threads:[~2024-09-07 20:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-07 16:28 Thoughts on the "branch <b> is not fully merged" error of "git-branch -d" Stefan Haller
2024-09-07 16:59 ` Junio C Hamano
2024-09-07 17:08 ` Junio C Hamano
2024-09-07 18:51 ` Stefan Haller
2024-09-07 20:00 ` Junio C Hamano [this message]
2024-09-08 5:33 ` Stefan Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmskjw7wr.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lists@haller-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).