From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Jeff King <peff@peff.net>, Kyle Lippincott <spectral@google.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: MSan failures in pack-bitmap
Date: Sun, 09 Jun 2024 11:55:07 -0700 [thread overview]
Message-ID: <xmqqmsnuaqus.fsf@gitster.g> (raw)
In-Reply-To: <ZmXKzJ9CpbYTmTwC@nand.local> (Taylor Blau's message of "Sun, 9 Jun 2024 11:31:24 -0400")
Taylor Blau <me@ttaylorr.com> writes:
> Unfortunately, the regression happened in 795006fff4, so this is in a
> released version of Git. But this is all behind a configuration option,
> so affected users can reasonably work around this issue.
Can you elaborate a bit about "reasonably work around"?
I am imagining that you are saying that the user can say "do not use
bitmap, because it may be corrupted due to an earlier regression" in
some configuration, so that a corrupt bitmap data is not used to
further spread the damage, but how does a user find out that on-disc
midx is broken and a workaround needs to be employed in the first
place? After working around the issue by avoiding to use the
corrupt on-disc data while waiting for a fixed version of Git to
come, what does the user need to do to start using the now-corrected
feature again? Does the fixed code notice there is an existing
breakage caused by the regression and remove the broken file
automatically?
Thanks.
next prev parent reply other threads:[~2024-06-09 18:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-08 2:43 MSan failures in pack-bitmap Kyle Lippincott
2024-06-08 8:18 ` Jeff King
2024-06-09 15:31 ` Taylor Blau
2024-06-09 18:55 ` Junio C Hamano [this message]
2024-06-09 20:00 ` Taylor Blau
2024-06-09 20:23 ` Junio C Hamano
2024-06-09 20:30 ` Taylor Blau
2024-06-09 20:24 ` Taylor Blau
2024-06-11 8:02 ` Jeff King
2024-06-11 9:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmsnuaqus.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=spectral@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).