From: Junio C Hamano <gitster@pobox.com>
To: "Beat Bolli" <bb@drbeat.li>
Cc: git@vger.kernel.org, Beat Bolli <dev+git@drbeat.li>,
Michael Osipov <michael.osipov@innomotics.com>
Subject: Re: [PATCH v2] date: make "iso-strict" conforming for the UTC timezone
Date: Wed, 13 Mar 2024 15:42:58 -0700 [thread overview]
Message-ID: <xmqqmsr169e5.fsf@gitster.g> (raw)
In-Reply-To: <20240313222922.11170-1-dev+git@drbeat.li> (Beat Bolli's message of "Wed, 13 Mar 2024 23:29:22 +0100")
"Beat Bolli" <bb@drbeat.li> writes:
> ISO 8601-1:2020-12 specifies that a zero timezone offset must be denoted
> with a "Z" suffix instead of the numeric "+00:00". Add the correponding
> special case to show_date() and a new test.
>
> This changes an established output format which might be depended on by
> scripts. The original patch 466fb6742d7f (pretty: provide a strict ISO
> 8601 date format, 2014-08-29) mentioned XML parsers as its rationale,
> which generally have good parsing support, so this change should be
> fine.
"fine." -> "fine for that particular usecase."
Unlike in 2005, we no longer write our features only for our own
single use case that motivated it. I do not think it is possible
to make this change without breaking some real script, and admitting
this is a breaking change and we are knowingly doing so is probably
better in the longer term.
Saying "this should be fine" in the log will give future developers
room to consider reverting it, and while they are free to make such
a decision based on the reality at their time in the future, we
should give them a data point from our point of view: we know it may
break somebody but we are still doing so knowingly as upside to
adhere to a published standard and help those users who adhere to
the same standard is more valuable then the unfortunate script that
bended themselves to match our earlier mistake.
Thanks.
next prev parent reply other threads:[~2024-03-13 22:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 11:27 log.date 'iso-strict' does not comply with ISO 8601-1:2020-12 Osipov, Michael (IN IT IN)
2024-03-13 17:50 ` [PATCH] date: make "iso-strict" conforming for the UTC timezone Beat Bolli
2024-03-13 18:30 ` Junio C Hamano
2024-03-13 19:29 ` Osipov, Michael (IN IT IN)
2024-03-13 22:29 ` [PATCH v2] " Beat Bolli
2024-03-13 22:42 ` Junio C Hamano [this message]
2024-03-13 22:54 ` [PATCH v3] " Beat Bolli
2024-03-13 23:06 ` Junio C Hamano
2024-03-13 19:27 ` [PATCH] " Osipov, Michael (IN IT IN)
2024-03-13 20:09 ` Kristoffer Haugsbakk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmsr169e5.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=bb@drbeat.li \
--cc=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=michael.osipov@innomotics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).