From: Junio C Hamano <gitster@pobox.com>
To: Elia Pinto <gitter.spiros@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] use C99 declaration of variable in for() loop
Date: Thu, 15 Feb 2024 12:07:01 -0800 [thread overview]
Message-ID: <xmqqmss1pk4a.fsf@gitster.g> (raw)
In-Reply-To: <CA+EOSBktLGnzi+DjOTVv9_cVNsM_fjEKiF9kWnaYrGtvGJ-Kdg@mail.gmail.com> (Elia Pinto's message of "Thu, 15 Feb 2024 19:56:40 +0100")
Elia Pinto <gitter.spiros@gmail.com> writes:
> Thank you for your reply. I can understand that, clearly. However,
> this means that extensive code
> refactoring contributions are never welcome. I am not saying this is a
> problem, but just an observation.
Such changes can happen and have happened when the benefit of such
code churn outweighs the cost of reviewing *and* cost of updating or
adjusting in-flight topics that may already or may not yet be in my
tree. Coccinelle-driven patches that can be mechanically reproduced
and whose validity can be trusted can be one way to reduce the review
and maintenance cost for such a tree-wide change.
next prev parent reply other threads:[~2024-02-15 20:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 9:42 [PATCH] use C99 declaration of variable in for() loop Elia Pinto
2024-02-15 17:33 ` Junio C Hamano
2024-02-15 18:17 ` Christian Couder
2024-02-15 18:49 ` Junio C Hamano
2024-02-15 18:56 ` Elia Pinto
2024-02-15 20:07 ` Junio C Hamano [this message]
2024-02-15 23:12 ` brian m. carlson
2024-02-15 23:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmss1pk4a.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).