From: Junio C Hamano <gitster@pobox.com>
To: Glen Choo <chooglen@google.com>
Cc: "Glen Choo via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Taylor Blau" <me@ttaylorr.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Elijah Newren" <newren@gmail.com>
Subject: Re: [PATCH 1/2] cocci: add headings to and reword README
Date: Thu, 13 Apr 2023 11:51:31 -0700 [thread overview]
Message-ID: <xmqqmt3by5sc.fsf@gitster.g> (raw)
In-Reply-To: <kl6lleivk4r1.fsf@chooglen-macbookpro.roam.corp.google.com> (Glen Choo's message of "Thu, 13 Apr 2023 11:37:38 -0700")
Glen Choo <chooglen@google.com> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>>> From: Glen Choo <chooglen@google.com>
>>>
>>> - Drop "examples" since we actually use the patches.
>>> - Drop sentences that could be headings instead
>>>
>>> Signed-off-by: Glen Choo <chooglen@google.com>
>>> ---
>>> contrib/coccinelle/README | 10 ++++++----
>>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> Makes sense. Will queue. Thanks.
>
> I believe this was directed at just the cleanups in this patch and not
> the recommendations in the later patch?
>
> I was confused for a moment when I first saw this, and someone else
> mentioned off-list that they also thought you meant you'd queue both
> patches.
Yes, I did mean that this step made sense (not implying anything
good or bad about the other step).
I ended up saving both on 'seen' so that we can keep track. I do
not think it is a problem---people can comment more on the patch and
I expect we would update it further.
THanks.
next prev parent reply other threads:[~2023-04-13 18:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 20:05 [PATCH 0/2] cocci: codify authoring and reviewing practices Glen Choo via GitGitGadget
2023-04-12 20:05 ` [PATCH 1/2] cocci: add headings to and reword README Glen Choo via GitGitGadget
2023-04-12 21:18 ` Junio C Hamano
2023-04-13 18:37 ` Glen Choo
2023-04-13 18:51 ` Junio C Hamano [this message]
2023-04-12 20:05 ` [PATCH 2/2] cocci: codify authoring and reviewing practices Glen Choo via GitGitGadget
2023-04-16 7:42 ` SZEDER Gábor
2023-04-19 19:29 ` Glen Choo
2023-04-20 20:53 ` [PATCH] cocci: remove 'unused.cocci' SZEDER Gábor
2023-04-21 2:43 ` Junio C Hamano
2023-05-01 13:27 ` Ævar Arnfjörð Bjarmason
2023-05-01 15:55 ` Junio C Hamano
2023-05-01 17:28 ` Ævar Arnfjörð Bjarmason
2023-05-10 22:45 ` Junio C Hamano
2023-04-16 13:37 ` [PATCH 2/2] cocci: codify authoring and reviewing practices Ævar Arnfjörð Bjarmason
2023-04-19 22:30 ` Glen Choo
2023-04-15 1:27 ` [PATCH 0/2] " Elijah Newren
2023-04-17 16:21 ` Junio C Hamano
2023-04-27 22:22 ` [PATCH v2 " Glen Choo via GitGitGadget
2023-04-27 22:22 ` [PATCH v2 1/2] cocci: add headings to and reword README Glen Choo via GitGitGadget
2023-05-01 10:53 ` Ævar Arnfjörð Bjarmason
2023-05-01 15:06 ` Junio C Hamano
2023-05-02 19:29 ` Felipe Contreras
2023-05-02 19:30 ` Felipe Contreras
2023-05-09 17:54 ` Glen Choo
2023-04-27 22:22 ` [PATCH v2 2/2] cocci: codify authoring and reviewing practices Glen Choo via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmt3by5sc.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=me@ttaylorr.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).