git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Rose via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Seija Kijin <doremylover123@gmail.com>
Subject: Re: [PATCH v8] curl: resolve deprecated curl declarations
Date: Tue, 17 Jan 2023 23:30:46 -0800	[thread overview]
Message-ID: <xmqqmt6g7109.fsf@gitster.g> (raw)
In-Reply-To: <pull.1435.v8.git.git.1673991669894.gitgitgadget@gmail.com> (Rose via GitGitGadget's message of "Tue, 17 Jan 2023 21:41:09 +0000")

"Rose via GitGitGadget" <gitgitgadget@gmail.com> writes:

> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1435%2FAtariDreams%2Fcurl-v8
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1435/AtariDreams/curl-v8
> Pull-Request: https://github.com/git/git/pull/1435
>
> Range-diff vs v7:
>
>  1:  23094afb2e6 ! 1:  5e44592695e curl: resolve deprecated curl declarations
> ...

Please stop throwing in quick succession so many unsolicited
iterations of the same topic at the list, before waiting for reviews
from others.

I do not mean "after you sent an initial revision out, even if you
find problems in it, do not send updates in for a while".  I mean
"do not send out that initial revision out, before you spend enough
time reading it to find these problems in it you found in, like you
did in these previous topics."

In other words, reviewing your own patches to carefully find
mistakes and correcting them is VERY GOOD, but rather than doing so
in public, you can do so in private before sending the patches out
to polish them sufficiently so that you won't find more trivial
problems [*].  Prepare patches in private and pretend to be a more
perfect human with fewer trivial mistakes ;-).

    Note. And you shouldn't be offended by me saying "trivial"; they
    were found by yourself in a few minutes to a few hours after
    you sent out the previous iteration.

That way, you'd save yourself from public embarrassment and also
save reviewer time.

Thanks.

P.S. Doesn't Peff's 3-patch series already solve the same issue this
patch is trying to address?

      reply	other threads:[~2023-01-18  7:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 19:27 [PATCH] curl: resolve deprecated curl declarations Rose via GitGitGadget
2023-01-17 19:43 ` [PATCH v2] " Rose via GitGitGadget
2023-01-17 20:02   ` [PATCH v3] " Rose via GitGitGadget
2023-01-17 20:09     ` [PATCH v4] " Rose via GitGitGadget
2023-01-17 20:19       ` [PATCH v5] " Rose via GitGitGadget
2023-01-17 20:22         ` [PATCH v6] " Rose via GitGitGadget
2023-01-17 20:33           ` [PATCH v7] " Rose via GitGitGadget
2023-01-17 21:41             ` [PATCH v8] " Rose via GitGitGadget
2023-01-18  7:30               ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmt6g7109.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=doremylover123@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).