git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <johannes.schindelin@gmx.de>,
	Johannes Sixt <j6t@kdbg.org>,
	Jeff Hostetler <jeffhost@microsoft.com>
Cc: "Harshil Jani via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Harshil Jani <harshiljani2002@gmail.com>
Subject: Re: [PATCH 0/2] Remove MSys Support
Date: Sun, 18 Dec 2022 11:15:57 +0900	[thread overview]
Message-ID: <xmqqmt7lxxr6.fsf@gitster.g> (raw)
In-Reply-To: <pull.1433.git.1670274213.gitgitgadget@gmail.com> (Harshil Jani via GitGitGadget's message of "Mon, 05 Dec 2022 21:03:31 +0000")

"Harshil Jani via GitGitGadget" <gitgitgadget@gmail.com> writes:

> The msysGit and the MSys v1.x has been dropped into this patch and the
> USE_NED_ALLOCATOR variable was duplicated here in the implementation so its
> deduplication was also made in this patch.
>
> Signed-off-by: Harshil-Jani harshiljani2002@gmail.com

Thanks, Harshil.

I do not do Windows, so I sent a few drive-by comments to suggest
improvements that may help to make the patch more understandable,
but more importantly, I did not see the patch asking input from
anybody who have worked on the port of Git to the Window system, so
I ran the following

$ git shortlog -sn --no-merges v2.39.0 -- compat/win\*\* compat/mingw.\* | head -5
   100	Johannes Schindelin
    56	Johannes Sixt
    41	Karsten Blees
    23	Erik Faye-Lund
    13	Jeff Hostetler

and then picked those names we still often see on the list to
attract their attention.


  parent reply	other threads:[~2022-12-18  2:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05 21:03 [PATCH 0/2] Remove MSys Support Harshil Jani via GitGitGadget
2022-12-05 21:03 ` [PATCH 1/2] mingw: remove duplicate `USE_NED_ALLOCATOR` directive Harshil-Jani via GitGitGadget
2022-12-18  1:54   ` Junio C Hamano
2022-12-05 21:03 ` [PATCH 2/2] mingw: remove msysGit/MSYS1 support Harshil-Jani via GitGitGadget
2022-12-18  2:11   ` Junio C Hamano
2022-12-18  3:58     ` Junio C Hamano
2023-01-09  7:48       ` Johannes Schindelin
2023-01-09  8:52         ` Junio C Hamano
2022-12-18  2:15 ` Junio C Hamano [this message]
2023-01-09  7:36   ` [PATCH 0/2] Remove MSys Support Johannes Schindelin
2023-01-09  8:49     ` Junio C Hamano
2023-02-02  3:51 ` [PATCH v2 " Harshil Jani via GitGitGadget
2023-02-02  3:51   ` [PATCH v2 1/2] mingw: remove duplicate `USE_NED_ALLOCATOR` directive Harshil-Jani via GitGitGadget
2023-02-02  3:51   ` [PATCH v2 2/2] mingw: remove msysGit/MSYS1 support Harshil-Jani via GitGitGadget
2023-02-02 13:59   ` [PATCH v2 0/2] Remove MSys Support Johannes Schindelin
2023-02-02 16:06     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmt7lxxr6.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=harshiljani2002@gmail.com \
    --cc=j6t@kdbg.org \
    --cc=jeffhost@microsoft.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).