From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Oscar Dominguez <dominguez.celada@gmail.com>
Subject: Re: [PATCH] ci: use actions/{upload,download}-artifact@v3
Date: Wed, 07 Dec 2022 08:41:21 +0900 [thread overview]
Message-ID: <xmqqmt8085i6.fsf@gitster.g> (raw)
In-Reply-To: <2s9ppo74-r654-231r-7ss7-o08464s2so6p@tzk.qr> (Johannes Schindelin's message of "Tue, 6 Dec 2022 22:21:23 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> @@ -210,7 +210,7 @@ jobs:
>> run: ci/print-test-failures.sh
>> - name: Upload failed tests' directories
>> if: failure() && env.FAILED_TEST_ARTIFACTS != ''
>> - uses: actions/upload-artifact@v2
>> + uses: actions/upload-artifact@v3
>
> This is probably incorrect, but you wouldn't know until something failed
> in the `linux32` job.
Yeah, that was what I was afraid to see.
> I already have a correct fix in
> https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c
> and was only waiting for the patch at the root of this here mail thread to
> advance further so I could contribute that fix, along with other
> replacements for deprecated operations.
Wonderful.
> Maybe we can move these changes forward in a more orderly manner, with
> Oscar's patch advancing to `next` once it is done, and the other patches
> following after that?
That was what I was planning to do anyway. Thanks.
next prev parent reply other threads:[~2022-12-06 23:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 7:48 [PATCH 0/2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget
2022-10-10 7:48 ` [PATCH 1/2] " Oscar Dominguez via GitGitGadget
2022-10-10 20:55 ` Junio C Hamano
2022-10-10 7:48 ` [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2 Oscar Dominguez via GitGitGadget
2022-10-10 21:00 ` Junio C Hamano
2022-10-10 21:43 ` Junio C Hamano
2022-12-05 10:01 ` [PATCH v2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget
2022-12-05 23:28 ` Junio C Hamano
2022-12-06 8:24 ` [PATCH] ci: use actions/{upload,download}-artifact@v3 Junio C Hamano
2022-12-06 21:21 ` Johannes Schindelin
2022-12-06 23:41 ` Junio C Hamano [this message]
2022-12-07 0:35 ` Junio C Hamano
2022-12-07 12:33 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmt8085i6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=dominguez.celada@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).