From: Junio C Hamano <gitster@pobox.com>
To: Jeff Hostetler <git@jeffhostetler.com>
Cc: Eric D <eric.decosta@gmail.com>, git@vger.kernel.org
Subject: Re: Option to allow fsmonitor to run against repos on network file systems
Date: Fri, 01 Jul 2022 11:41:12 -0700 [thread overview]
Message-ID: <xmqqmtds8ylz.fsf@gitster.g> (raw)
In-Reply-To: <16832f8a-c582-23bb-dda9-b7b2597a42eb@jeffhostetler.com> (Jeff Hostetler's message of "Fri, 1 Jul 2022 09:32:37 -0400")
Jeff Hostetler <git@jeffhostetler.com> writes:
> Having said all of that, I did do lots of testing and never had an
> issue with remote drives actually working correctly, so I think it'd
> be fine allow a config setting to optionally allow it. I just didn't
> want to clutter up things in advance if no one actually wanted to
> use it on remote file systems.
>
> I think it would be fine to have a "fsmonitor.allowRemote" or
> "fsmonitor.allowWindowsRemote" config setting and default them to false
> for now. Or until we learn which combinations of remote mounts are
> safe and/or problematic.
How about getting rid of "is this remote?" check altogether (which
presumably would simplify the logic) and make it totally up to the
user of the repository? fsmonitor.disableInRepository that is set
in ~/.gitignore and lists the paths to the repositories (like
safe.directory does), for which fsmonitor gets disabled, may be a
handy mechanism to set up the default (and it can be re-enabled with
per-repository core.fsmonitor).
next prev parent reply other threads:[~2022-07-01 18:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 17:11 Option to allow fsmonitor to run against repos on network file systems Eric D
2022-07-01 13:32 ` Jeff Hostetler
2022-07-01 18:41 ` Junio C Hamano [this message]
2022-07-01 19:15 ` Eric D
2022-08-01 18:35 ` Eric D
2022-08-08 21:58 ` Eric D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmtds8ylz.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=eric.decosta@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).