From: Junio C Hamano <gitster@pobox.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: Git List <git@vger.kernel.org>, pudinha <rogi@skylittlesystem.org>
Subject: Re: [BUG] Regression in 'git mergetool --tool-help'
Date: Fri, 18 Dec 2020 21:16:03 -0800 [thread overview]
Message-ID: <xmqqmtyaqsto.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CADtb9DyozjgAsdFYL8fFBEWmq7iz4=prZYVUdH9W-J5CKVS4OA@mail.gmail.com> (Philippe Blain's message of "Fri, 18 Dec 2020 23:23:41 -0500")
diff --git a/git-mergetool--lib.sh b/git-mergetool--lib.sh
index 204a5acd66..29fecc340f 100644
--- a/git-mergetool--lib.sh
+++ b/git-mergetool--lib.sh
@@ -43,7 +43,14 @@ show_tool_names () {
shown_any=
( cd "$MERGE_TOOLS_DIR" && ls ) | {
- while read toolname
+ while read scriptname
+ do
+ setup_tool "$scriptname" 2>/dev/null
+ variants="$variants$(list_tool_variants)\n"
Ahh, that does look quite bogus as \n won't do anything useful
there. And I do not think we _need_ to use LF there.
+ done
+ variants="$(echo "$variants" | sort | uniq)"
+
+ for toolname in $variants
Just replace \n with " " (whitespace) and do something like this,
perhaps?
variants="$variantes$(list_tool_variants) "
done
variants=$(printf "%s\n" $variants | sort | uniq)
prev parent reply other threads:[~2020-12-19 5:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-19 4:23 [BUG] Regression in 'git mergetool --tool-help' Philippe Blain
2020-12-19 4:50 ` Felipe Contreras
2020-12-19 5:33 ` Junio C Hamano
2020-12-19 12:10 ` Felipe Contreras
2020-12-19 17:13 ` Junio C Hamano
2020-12-20 2:13 ` Philippe Blain
2020-12-20 10:28 ` Johannes Sixt
2020-12-20 16:23 ` René Scharfe
2020-12-20 18:11 ` Junio C Hamano
2020-12-20 23:47 ` Philippe Blain
2020-12-21 0:41 ` Junio C Hamano
2020-12-20 15:34 ` Junio C Hamano
2020-12-19 5:16 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmtyaqsto.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=levraiphilippeblain@gmail.com \
--cc=rogi@skylittlesystem.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).