git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Manish Goregaokar via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Manish Goregaokar <manishsmail@gmail.com>
Subject: Re: [PATCH v3 1/1] submodule: fix 'submodule status' when called from a subdirectory
Date: Mon, 25 Nov 2019 13:51:24 +0900	[thread overview]
Message-ID: <xmqqmucky2wj.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <8dcea6b399923e931625ef09d66661e93975b93a.1574655344.git.gitgitgadget@gmail.com> (Manish Goregaokar via GitGitGadget's message of "Mon, 25 Nov 2019 04:15:44 +0000")

"Manish Goregaokar via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> +		test_cmp ../expect ../actual &&

Note that "test_cmp expect actual" highlights a breakage, when it
finds one, by showing a diff that shows "what we saw is different
from what we expected to see in this way".  So this invocation is
good.

> +		git -C ../submod checkout HEAD^ &&
> +		git submodule status >../output &&
> +		awk "{print \$1}" <../output >../actual2 &&
> +		cd .. &&
> +		git submodule status >output &&
> +		awk "{print \$1}" <output >expect2 &&
> +		test_cmp actual2 expect2 &&

But this one is probably the other way around.  I'll fix this up
while queuing, so if there is no other changes necessary, there is
no need to resend the patch.

> +		! test_cmp actual actual2

And the order of this one actually does not matter ;-)

> +	)
> +'

Thanks.

  reply	other threads:[~2019-11-25  4:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23  6:28 [PATCH 0/1] submodule: Fix 'submodule status' when called from a subdirectory Manish Goregaokar via GitGitGadget
2019-11-23  6:28 ` [PATCH 1/1] " Manish Goregaokar via GitGitGadget
2019-11-24  5:17   ` Junio C Hamano
2019-11-24  8:01 ` [PATCH v2 0/1] " Manish Goregaokar via GitGitGadget
2019-11-24  8:01   ` [PATCH v2 1/1] submodule: fix " Manish Goregaokar via GitGitGadget
2019-11-25  1:56     ` Junio C Hamano
2019-11-25  4:08       ` Manish Goregaokar
2019-11-25  4:15   ` [PATCH v3 0/1] submodule: Fix " Manish Goregaokar via GitGitGadget
2019-11-25  4:15     ` [PATCH v3 1/1] submodule: fix " Manish Goregaokar via GitGitGadget
2019-11-25  4:51       ` Junio C Hamano [this message]
2019-11-25  6:32         ` Manish Goregaokar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmucky2wj.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=manishsmail@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).