From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Taylor Blau <me@ttaylorr.com>, git@vger.kernel.org
Subject: Re: [PATCH] t: use LF variable defined in the test harness
Date: Thu, 05 Sep 2019 12:34:02 -0700 [thread overview]
Message-ID: <xmqqmufipmfp.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190905184716.GA12647@sigill.intra.peff.net> (Jeff King's message of "Thu, 5 Sep 2019 14:47:16 -0400")
Jeff King <peff@peff.net> writes:
> On Thu, Sep 05, 2019 at 11:17:57AM -0700, Junio C Hamano wrote:
>
>> Somebody may want to go clean-up the use of various $sq and $SQ
>> locally defined by giving a unified $SQ in test-lib.sh, by the way.
>
> Maybe good #leftoverbits material, since we may have Outreachy
> applications coming up soon.
OK, then I'd refrain from doing it as a lunchtime hack myself ;-)
* Find sq=, $sq and ${sq} case insensitively in t/. If there is
any use of $SQ that does not want a single quote in it, abort
the whole thing. Otherwise proceed.
* Introduce an assignment SQ=\' in t/test-lib.sh, next to where LF
is assigned to. Replace all uses you found in #1 with reference
to $SQ.
#leftoverbits.
next prev parent reply other threads:[~2019-09-05 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 21:11 [PATCH] t: use LF variable defined in the test harness Junio C Hamano
2019-09-04 0:29 ` Taylor Blau
2019-09-05 18:17 ` Junio C Hamano
2019-09-05 18:47 ` Jeff King
2019-09-05 19:34 ` Junio C Hamano [this message]
2019-09-05 22:10 ` [PATCH] t: use common $SQ variable Denton Liu
2019-09-05 22:25 ` Taylor Blau
2019-09-05 22:27 ` Taylor Blau
2019-09-06 2:04 ` Denton Liu
2019-09-05 18:52 ` [PATCH] t: use LF variable defined in the test harness Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmufipmfp.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).