git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] read-tree.txt: clarify --reset and worktree changes
Date: Mon, 01 Apr 2019 19:47:20 +0900	[thread overview]
Message-ID: <xmqqmulauhmv.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: 20190326120939.31657-1-pclouds@gmail.com

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> diff --git a/Documentation/git-read-tree.txt b/Documentation/git-read-tree.txt
> index 5c70bc2878..12a25bc954 100644
> --- a/Documentation/git-read-tree.txt
> +++ b/Documentation/git-read-tree.txt
> @@ -38,8 +38,9 @@ OPTIONS
>  	started.
>  
>  --reset::
> -        Same as -m, except that unmerged entries are discarded
> -        instead of failing.
> +	Same as -m, except that unmerged entries are discarded
> +	instead of failing. If `-u` is used, updates leading to loss
> +	of local changes will not abort the operation.

"git add $file" makes a local change to the index at path $file",
and reverting that local change is what "read-tree --reset"
primarily does.

The difference cased by presence or lack of "-u" is only about the
working tree files, so s/local/working tree/ perhaps?

I'd also phrase s/If `-u` is used/When used with `-u`/ if I were
writing this.

Thanks.

>  
>  -u::
>  	After a successful merge, update the files in the work

  reply	other threads:[~2019-04-01 10:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 12:09 [PATCH] read-tree.txt: clarify --reset and worktree changes Nguyễn Thái Ngọc Duy
2019-04-01 10:47 ` Junio C Hamano [this message]
2019-04-01 12:02   ` Duy Nguyen
2019-04-01 12:05 ` [PATCH v2] " Nguyễn Thái Ngọc Duy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmulauhmv.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).