From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Sebastian Staudt <koraktor@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Duy Nguyen <pclouds@gmail.com>
Subject: Re: [PATCH v3 1/3] Add tests for describe with --work-tree
Date: Tue, 29 Jan 2019 09:47:35 -0800 [thread overview]
Message-ID: <xmqqmunj8ifc.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190129130031.GA22211@sigill.intra.peff.net> (Jeff King's message of "Tue, 29 Jan 2019 08:00:32 -0500")
Jeff King <peff@peff.net> writes:
> The usual style is to put the whole snippet into single-quotes, and then
> double-quote as appropriate within it. Like:
>
> test_expect_failure 'describe --dirty with --work-tree' '
> (
> cd "$TEST_DIRECTORY" &&
> git --git-dir "$TRASH_DIRECTORY/.git" ...etc
>
> Those variables will be expanded when test_expect_failure eval's the
> snippet.
Good.
>> + grep 'A-\d\+-g[0-9a-f]\+' '$TRASH_DIRECTORY/out'
>
> Using "\d" isn't portable.
True, but not just \d. I think using \ before special characters to
force an otherwise basic regular expression to be ERE (i.e. \+ at
the end) is a GNUism.
> This regex is pretty broad. What are we checking here? If I understand
> the previous discussion, we just care that it doesn't have "dirty" in
> it, right? I don't think this regex does that, because it doesn't anchor
> the end of string.
>
> If that's indeed what we're checking, then an easier check is perhaps:
>
> ! grep dirty ...
Good.
next prev parent reply other threads:[~2019-01-29 17:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 5:18 [PATCH v3 1/3] Add tests for describe with --work-tree Sebastian Staudt
2019-01-29 5:18 ` [PATCH v3 2/3] Setup working tree in describe Sebastian Staudt
2019-01-29 13:11 ` Jeff King
2019-01-29 17:39 ` Junio C Hamano
2019-01-29 20:53 ` Eric Sunshine
2019-01-29 22:35 ` Jeff King
2019-01-30 10:31 ` Sebastian Staudt
2019-01-30 12:44 ` Jeff King
2019-01-29 5:18 ` [PATCH v3 3/3] Add test for describe with a bare repository Sebastian Staudt
2019-01-29 13:12 ` Jeff King
2019-01-30 10:23 ` Sebastian Staudt
2019-01-29 13:00 ` [PATCH v3 1/3] Add tests for describe with --work-tree Jeff King
2019-01-29 17:47 ` Junio C Hamano [this message]
2019-01-30 10:23 ` Sebastian Staudt
2019-01-30 12:43 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmunj8ifc.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=koraktor@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).