From: Junio C Hamano <gitster@pobox.com>
To: pedrodelyra@gmail.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH] setup.c: remove needless argument passed to open in sanitize_stdfds
Date: Mon, 26 Nov 2018 13:39:04 +0900 [thread overview]
Message-ID: <xmqqmupwzc47.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20181125162008.30065-1-pedrodelyra@gmail.com> (pedrodelyra's message of "Sun, 25 Nov 2018 14:20:08 -0200")
pedrodelyra@gmail.com writes:
> According to POSIX manual pages, the open() system call's mode
> argument specifies the file mode bits to be applied when a new
> file is created. If neither O_CREAT nor O_TMPFILE is specified,
> then mode is ignored.
Correct.
While I would say two argument form would have been better if this
were a new code, this change is borderline Meh for existing code,
because passing 0 there already gives a reasonable sign that we know
this parameter does not matter.
If the ignored parameter were 0666 or some other more
plausible-as-perm-bits value, the story would be quite different,
though.
Thanks.
prev parent reply other threads:[~2018-11-26 4:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 16:20 [PATCH] setup.c: remove needless argument passed to open in sanitize_stdfds pedrodelyra
2018-11-26 4:39 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmupwzc47.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pedrodelyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).