From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: Johannes.Schindelin@gmx.de, git@vger.kernel.org, sunshine@sunshineco.com
Subject: Re: [PATCH 2/8] t3206: add color test for range-diff --dual-color
Date: Tue, 31 Jul 2018 13:51:33 -0700 [thread overview]
Message-ID: <xmqqmuu79lii.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180731003141.105192-3-sbeller@google.com> (Stefan Beller's message of "Mon, 30 Jul 2018 17:31:35 -0700")
Stefan Beller <sbeller@google.com> writes:
> The 'expect'ed outcome has been taken by running the 'range-diff | decode'.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> t/t3206-range-diff.sh | 39 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh
> index 2237c7f4af9..019724e61a0 100755
> --- a/t/t3206-range-diff.sh
> +++ b/t/t3206-range-diff.sh
> @@ -142,4 +142,43 @@ test_expect_success 'changed message' '
> test_cmp expected actual
> '
>
> +test_expect_success 'dual-coloring' '
> + cat >expect <<-\EOF &&
It is a good idea to use something like "sed -e 's/^|//'" instead of
"cat" here; that way allows you to mark the left-edge of the data
with "|", for a test vector like this one that has a line that would
otherwise violate the whitespace style rules.
An inferiour alternative would be to add .gitaddtibute entry to make
this file exempt from indent-with-tab rule, but even in this 40-line
block there only is one line that requires such a workaround, and it
won't help the initial application of this patch to get modified
when applied with "am --whitespace=fix".
> + <YELLOW>1: a4b3333 = 1: f686024 s/5/A/<RESET>
> + <RED>2: f51d370 <RESET><YELLOW>!<RESET><GREEN> 2: 4ab067d<RESET><YELLOW> s/4/A/<RESET>
> + <REVERSE><CYAN>@@ -2,6 +2,8 @@<RESET>
> + <RESET>
> + s/4/A/<RESET>
> + <RESET>
> + <REVERSE><GREEN>+<RESET> <BOLD> Also a silly comment here!<RESET>
> + <REVERSE><GREEN>+<RESET>
> + diff --git a/file b/file<RESET>
> + <RED> --- a/file<RESET>
> + <GREEN> +++ b/file<RESET>
> + <RED>3: 0559556 <RESET><YELLOW>!<RESET><GREEN> 3: b9cb956<RESET><YELLOW> s/11/B/<RESET>
> + <REVERSE><CYAN>@@ -10,7 +10,7 @@<RESET>
> + 9<RESET>
> + 10<RESET>
> + <RED> -11<RESET>
> + <REVERSE><RED>-<RESET><FAINT;GREEN>+BB<RESET>
> + <REVERSE><GREEN>+<RESET><BOLD;GREEN>+B<RESET>
> + 12<RESET>
> + 13<RESET>
> + 14<RESET>
> + <RED>4: d966c5c <RESET><YELLOW>!<RESET><GREEN> 4: 8add5f1<RESET><YELLOW> s/12/B/<RESET>
> + <REVERSE><CYAN>@@ -8,7 +8,7 @@<RESET>
> + <CYAN> @@<RESET>
> + 9<RESET>
> + 10<RESET>
> + <REVERSE><RED>-<RESET><FAINT> BB<RESET>
> + <REVERSE><GREEN>+<RESET> <BOLD>B<RESET>
> + <RED> -12<RESET>
> + <GREEN> +B<RESET>
> + 13<RESET>
> + EOF
> + git range-diff changed...changed-message --color --dual-color >actual.raw &&
> + test_decode_color >actual <actual.raw &&
> + test_cmp expect actual
> +'
> +
> test_done
next prev parent reply other threads:[~2018-07-31 20:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-28 3:04 [PATCH 0/8] Add color test for range-diff, simplify diff.c Stefan Beller
2018-07-28 3:04 ` [PATCH 1/8] test_decode_color: understand FAINT and ITALIC Stefan Beller
2018-07-28 3:04 ` [PATCH 2/8] t3206: add color test for range-diff --dual-color Stefan Beller
2018-07-28 6:27 ` Eric Sunshine
2018-07-30 19:55 ` Stefan Beller
2018-07-28 3:04 ` [PATCH 3/8] diff.c: simplify caller of emit_line_0 Stefan Beller
2018-07-28 3:04 ` [PATCH 4/8] diff.c: reorder arguments for emit_line_ws_markup Stefan Beller
2018-07-28 3:04 ` [PATCH 5/8] diff.c: add set_sign to emit_line_0 Stefan Beller
2018-07-28 6:30 ` Eric Sunshine
2018-07-28 3:04 ` [PATCH 6/8] diff: use emit_line_0 once per line Stefan Beller
2018-07-28 3:04 ` [PATCH 7/8] diff.c: compute reverse locally in emit_line_0 Stefan Beller
2018-07-28 3:04 ` [PATCH 8/8] diff.c: rewrite emit_line_0 more understandably Stefan Beller
2018-07-28 6:33 ` Eric Sunshine
2018-07-31 0:31 ` [PATCHv2 0/8] Add color test for range-diff, simplify diff.c Stefan Beller
2018-07-31 0:31 ` [PATCH 1/8] test_decode_color: understand FAINT and ITALIC Stefan Beller
2018-07-31 0:31 ` [PATCH 2/8] t3206: add color test for range-diff --dual-color Stefan Beller
2018-07-31 20:51 ` Junio C Hamano [this message]
2018-07-31 0:31 ` [PATCH 3/8] diff.c: simplify caller of emit_line_0 Stefan Beller
2018-07-31 0:31 ` [PATCH 4/8] diff.c: reorder arguments for emit_line_ws_markup Stefan Beller
2018-07-31 0:31 ` [PATCH 5/8] diff.c: add set_sign to emit_line_0 Stefan Beller
2018-07-31 0:31 ` [PATCH 6/8] diff: use emit_line_0 once per line Stefan Beller
2018-07-31 0:31 ` [PATCH 7/8] diff.c: compute reverse locally in emit_line_0 Stefan Beller
2018-07-31 0:31 ` [PATCH 8/8] diff.c: rewrite emit_line_0 more understandably Stefan Beller
2018-08-01 19:13 ` [PATCHv2 0/8] Add color test for range-diff, simplify diff.c Junio C Hamano
2018-08-01 19:46 ` Stefan Beller
2018-08-02 15:48 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2018-08-10 22:34 [PATCH 0/8] Resending sb/range-diff-colors Stefan Beller
2018-08-10 22:34 ` [PATCH 2/8] t3206: add color test for range-diff --dual-color Stefan Beller
2018-08-13 12:05 ` Johannes Schindelin
2018-08-13 18:30 ` Stefan Beller
2018-08-14 1:41 ` [PATCHv2 0/8] Resending sb/range-diff-colors Stefan Beller
2018-08-14 1:41 ` [PATCH 2/8] t3206: add color test for range-diff --dual-color Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmuu79lii.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).