From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, T_DKIM_INVALID shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 5A2591F597 for ; Fri, 27 Jul 2018 19:29:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389209AbeG0UxA (ORCPT ); Fri, 27 Jul 2018 16:53:00 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:38242 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389159AbeG0UxA (ORCPT ); Fri, 27 Jul 2018 16:53:00 -0400 Received: by mail-wr1-f65.google.com with SMTP id v14-v6so6099395wro.5 for ; Fri, 27 Jul 2018 12:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Otw4Ow18qtNRRObVtIlC7LD9pKkiMmF7iWikWVY2zDM=; b=BGH79U58sv1vFICIu7ZVLIKqec+h/WCno2AsRvrRHPSSQoeKFdcimq2Z0CIrZ7e29t VbD7OFsRxPp6AFJ38dFzO0v126hXrhrXPJPSLRNX8DnUAUhc3jIQbKQihOz4i/ODYVwa valtXCjNGCTM9zWoxQEBXmF9Zy0rk157Sjj8rMd/qVclO1lWdqDubXsEO6lkMpV3Gbxg CVaczmZccVAMU6UbR/OeYVOIfOXxjrvK5ik4B4CkfdvarUJz9m/xYmotfFdunac7GK9K mGtM43ed6midaIKYCBiZ2RA/L43L1YF/TnrkoGFluz+2Z77pJwHL+f9U1YfXei30qPXe pjSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=Otw4Ow18qtNRRObVtIlC7LD9pKkiMmF7iWikWVY2zDM=; b=kx7EO5fNo96NteaCgLUBdfXRMmmDyXrPFTpeXPaCF5Hd/gfZocBa3Afz8fIp5BLWud XTIpJhMqbETvg3P5mLgcDGwojkI4EMl9OIAzYcf44n4VgOAs5CQa7Rp0L2Sip9pQA8cx ww+NGheM5cY/caSrOMntjj63SG4ExIPOAesrRAFTWoMSs1ZiWXtt7OdZfwGy8L4gPJOv 2v4SpFXXVxLkJfkGqhMGSp0IpyMB+ySvrCJea53yPBmhi9T14CFTdiTphEwkRZ7GFCEi xQCakB1PLsEfa/orWH/OrlWzhvd7u4PJi2mUhxRSFlTwi64U7RjCHibu/R0vWfkzs8IB gYEA== X-Gm-Message-State: AOUpUlEi0ODcenH3GnCyfjbw4GM8DYtueVWG6yQsq9TZAKoB0ABLanLO e26Sh4W3qIGarSpKhEWyHFpKVg51 X-Google-Smtp-Source: AAOMgpfrPV0AButIGMIGX9xh9qe/rABpkxT/kpbg+tIbhszT2mOiCzynP17KtyWY5PWvkuWHAcIHSQ== X-Received: by 2002:a5d:61ca:: with SMTP id q10-v6mr6047820wrv.33.1532719780427; Fri, 27 Jul 2018 12:29:40 -0700 (PDT) Received: from localhost (112.68.155.104.bc.googleusercontent.com. [104.155.68.112]) by smtp.gmail.com with ESMTPSA id v1-v6sm8699056wrs.34.2018.07.27.12.29.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Jul 2018 12:29:39 -0700 (PDT) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Johannes Schindelin , Jeff King , Eric Sunshine , Christian Couder Subject: Re: [PATCH v3 03/10] config doc: unify the description of fsck.* and receive.fsck.* References: <20180525192811.25680-1-avarab@gmail.com> <20180727143720.14948-4-avarab@gmail.com> Date: Fri, 27 Jul 2018 12:29:39 -0700 In-Reply-To: <20180727143720.14948-4-avarab@gmail.com> (=?utf-8?B?IsOGdmFy?= =?utf-8?B?IEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Fri, 27 Jul 2018 14:37:13 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Ævar Arnfjörð Bjarmason writes: > The documentation for the fsck. and receive.fsck. > variables was mostly duplicated in two places, with fsck. > making no mention of the corresponding receive.fsck., and the > same for fsck.skipList. Overall the result reads a lot easily. Especially this part: > + During fsck git may find issues with legacy data which > + wouldn't be generated by current versions of git, and which > + wouldn't be sent over the wire if `transfer.fsckObjects` was > + set. This feature is intended to support working with legacy > + repositories containing such data. that adds only a few sentences and clarifies the impact of "legacy"-ness to this issue rather nicely. I first found it a bit odd that fsck.* and receive.fsck.* are discussed with an apparent asymmetry but it actually is correct, because we haven't introduced fetch.fsck.* at this step in the series. Thanks.