From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] commit.h: rearrange 'index' to shrink struct commit
Date: Sun, 13 May 2018 11:03:49 +0900 [thread overview]
Message-ID: <xmqqmux4e2gq.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180511172054.7684-1-pclouds@gmail.com> ("Nguyễn Thái Ngọc Duy"'s message of "Fri, 11 May 2018 19:20:54 +0200")
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> On linux 64-bit architecture, pahole finds that there's a 4 bytes
> padding after 'index'. Moving it to the end reduces this struct's size
> from 72 to 64 bytes (because of another 4 bytes padding after
> graph_pos). On linux 32-bit, the struct size remains 52 bytes like
> before.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> commit.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/commit.h b/commit.h
> index e57ae4b583..fd1cbe7263 100644
> --- a/commit.h
> +++ b/commit.h
> @@ -19,11 +19,11 @@ struct commit_list {
> struct commit {
> struct object object;
> void *util;
> - unsigned int index;
> timestamp_t date;
> struct commit_list *parents;
> struct tree *tree;
> uint32_t graph_pos;
> + unsigned int index;
> };
>
> extern int save_commit_buffer;
Quite nice.
prev parent reply other threads:[~2018-05-13 2:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 17:20 [PATCH] commit.h: rearrange 'index' to shrink struct commit Nguyễn Thái Ngọc Duy
2018-05-13 2:03 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmux4e2gq.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).