From: Junio C Hamano <gitster@pobox.com>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: Daniel Ferreira <bnmvco@gmail.com>,
git@vger.kernel.org, sbeller@google.com, pclouds@gmail.com
Subject: Re: [PATCH v4 2/5] dir_iterator: iterate over dir after its contents
Date: Thu, 30 Mar 2017 10:26:15 -0700 [thread overview]
Message-ID: <xmqqmvc265hk.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1751d788-d1f1-1c97-b33b-f53dab78ef86@alum.mit.edu> (Michael Haggerty's message of "Thu, 30 Mar 2017 08:39:28 +0200")
Michael Haggerty <mhagger@alum.mit.edu> writes:
> I don't think any of this needs to be implemented now, but maybe keep it
> in mind if/when `dir_iterator` gets more users.
OK. One thing that was missing in your list was the opposite of "do
not show directories", i.e. "show only directories". That should
also be easy to do (but we need to figure out a way to encode it in
the flag somehow) if it turns out to be useful later.
next prev parent reply other threads:[~2017-03-30 17:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 0:32 [PATCH v4 0/5] [GSoC] remove_subtree(): reimplement using iterators Daniel Ferreira
2017-03-29 0:32 ` [PATCH v4 1/5] dir_iterator: add helpers to dir_iterator_advance Daniel Ferreira
2017-03-29 4:32 ` Michael Haggerty
2017-03-29 0:32 ` [PATCH v4 2/5] dir_iterator: iterate over dir after its contents Daniel Ferreira
2017-03-29 9:56 ` Michael Haggerty
2017-03-29 10:44 ` Michael Haggerty
2017-03-29 16:46 ` Junio C Hamano
2017-03-30 4:59 ` Michael Haggerty
2017-03-30 6:08 ` Junio C Hamano
2017-03-30 6:39 ` Michael Haggerty
2017-03-30 11:08 ` Duy Nguyen
2017-04-02 4:25 ` Daniel Ferreira (theiostream)
2017-04-05 9:21 ` Duy Nguyen
2017-03-30 17:26 ` Junio C Hamano [this message]
2017-03-29 0:32 ` [PATCH v4 3/5] remove_subtree(): reimplement using iterators Daniel Ferreira
2017-03-29 10:01 ` Michael Haggerty
2017-03-29 0:32 ` [PATCH v4 4/5] remove_subtree(): test removing nested directories Daniel Ferreira
2017-03-29 0:32 ` [PATCH v4 5/5] files_reflog_iterator: amend use of dir_iterator Daniel Ferreira
2017-03-29 10:45 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmvc265hk.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=bnmvco@gmail.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).