From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org, "Michael Blume" <blume.mike@gmail.com>,
"Torsten Bögershausen" <tboegi@web.de>,
"David Aguilar" <davvid@gmail.com>
Subject: Re: [PATCH] git-compat-util: suppress unavoidable Apple-specific deprecation warnings
Date: Wed, 17 Dec 2014 14:33:46 -0800 [thread overview]
Message-ID: <xmqqmw6l9a9h.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1418771976-15060-1-git-send-email-sunshine@sunshineco.com> (Eric Sunshine's message of "Tue, 16 Dec 2014 18:19:36 -0500")
Eric Sunshine <sunshine@sunshineco.com> writes:
> These Apple-specific warnings are pure noise: they don't tell us
> anything useful and we have no control over them, nor is Apple likely to
> provide replacements any time soon. Such noise may obscure other
> legitimate warnings, therefore silence them.
Sad but it appears to me that it is the best we could do...
Will queue. Thanks.
>
> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
> ---
>
> Related discussion:
> http://thread.gmane.org/gmane.comp.version-control.git/260463/
>
> git-compat-util.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/git-compat-util.h b/git-compat-util.h
> index 400e921..433b8f2 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -211,8 +211,12 @@ extern char *gitbasename(char *);
> #endif
>
> #ifndef NO_OPENSSL
> +#define __AVAILABILITY_MACROS_USES_AVAILABILITY 0
> +#define MAC_OS_X_VERSION_MIN_REQUIRED MAC_OS_X_VERSION_10_6
> #include <openssl/ssl.h>
> #include <openssl/err.h>
> +#undef MAC_OS_X_VERSION_MIN_REQUIRED
> +#undef __AVAILABILITY_MACROS_USES_AVAILABILITY
> #endif
>
> /* On most systems <netdb.h> would have given us this, but
next prev parent reply other threads:[~2014-12-17 22:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 23:19 [PATCH] git-compat-util: suppress unavoidable Apple-specific deprecation warnings Eric Sunshine
2014-12-17 22:33 ` Junio C Hamano [this message]
2014-12-18 14:03 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmw6l9a9h.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=blume.mike@gmail.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).