From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Siddharth Agarwal <sid0@fb.com>,
git@vger.kernel.org, bmaurer@fb.com,
Aaron Kushner <akushner@fb.com>
Subject: Re: with reuse-delta patches, fetching with bitmaps segfaults due to possibly incomplete bitmap traverse
Date: Mon, 24 Mar 2014 13:30:58 -0700 [thread overview]
Message-ID: <xmqqmwgfpce5.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140322125626.GA22890@sigill.intra.peff.net> (Jeff King's message of "Sat, 22 Mar 2014 08:56:27 -0400")
Jeff King <peff@peff.net> writes:
> On Fri, Mar 21, 2014 at 07:58:55PM -0700, Siddharth Agarwal wrote:
>
>> At Facebook we've found that fetch speed is a bottleneck for our Git repos,
>> so we've been looking to deploy bitmaps to speed up fetches. We've been
>> trying out git-next with the top two patches from
>> https://github.com/peff/git/commits/jk/bitmap-reuse-delta, but the following
>> is reproducible with tip of that branch, currently 81cdec2.
>
> Is it also reproducible just with the tip of "next"? Note that the
> patches in jk/bitmap-reuse-delta have not been widely deployed (in
> particular, we are not yet using them at GitHub, and we track segfaults
> on our servers closely and have not seen any related to this).
Nice to hear. I was worried for a short while if I merged what was
not cooked well, before I realized that Siddharth is on a codebase
that is more bleeding edge than I use myself ;-)
prev parent reply other threads:[~2014-03-24 20:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-22 2:58 with reuse-delta patches, fetching with bitmaps segfaults due to possibly incomplete bitmap traverse Siddharth Agarwal
2014-03-22 12:56 ` Jeff King
2014-03-24 0:01 ` Siddharth Agarwal
2014-03-24 20:30 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmwgfpce5.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=akushner@fb.com \
--cc=bmaurer@fb.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sid0@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).