From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH 0/3] bloom-related leak fixes
Date: Wed, 01 Jul 2026 10:33:26 -0700 [thread overview]
Message-ID: <xmqqo6gqobrt.fsf@gitster.g> (raw)
In-Reply-To: <b641aed4-ad52-477b-b1d8-9d8e470be46f@gmail.com> (Derrick Stolee's message of "Wed, 1 Jul 2026 10:32:39 -0400")
Derrick Stolee <stolee@gmail.com> writes:
> On 7/1/2026 2:35 AM, Jeff King wrote:
>> Here are a few small leak fixes that only show up when you run the test
>> suite with GIT_TEST_COMMIT_GRAPH_CHANGED_PATHS=1.
>>
>> Combined with the commit-graph leak-fix here:
>>
>> https://lore.kernel.org/git/20260630064301.GB3733961@coredump.intra.peff.net/
>>
>> and Kaartic's pending fix from this thread:
>>
>> https://lore.kernel.org/git/20260614141600.620272-1-kaartic.sivaraam@gmail.com/
>>
>> This will fix most of the leaks we'd see if we ran linux-TEST-vars jobs
>> with leak-checking. There are a few more related to building with
>> openssl for sha1, but I'll tackle those separately.
> Thanks for fixing these leaks in the simplest way possible in
> each scenario.
Yup, these were delight to read.
prev parent reply other threads:[~2026-07-01 17:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 6:35 [PATCH 0/3] bloom-related leak fixes Jeff King
2026-07-01 6:39 ` [PATCH 1/3] bloom: make bloom-filter slab initialization idempotent Jeff King
2026-07-01 13:53 ` Derrick Stolee
2026-07-01 15:50 ` Junio C Hamano
2026-07-01 6:40 ` [PATCH 2/3] revision: avoid leaking bloom keyvecs with multiple traversals Jeff King
2026-07-01 8:26 ` Patrick Steinhardt
2026-07-01 14:21 ` Derrick Stolee
2026-07-01 15:52 ` Junio C Hamano
2026-07-01 6:42 ` [PATCH 3/3] line-log: drop extra copy of range with bloom filters Jeff King
2026-07-01 14:32 ` [PATCH 0/3] bloom-related leak fixes Derrick Stolee
2026-07-01 17:33 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo6gqobrt.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox