Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Brandon Dong via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Brandon Dong <brandondong96@gmail.com>
Subject: Re: [PATCH] doc: add missing --message long option to merge docs
Date: Fri, 29 May 2026 14:02:51 +0900	[thread overview]
Message-ID: <xmqqo6hyiz9g.fsf@gitster.g> (raw)
In-Reply-To: <pull.2315.git.git.1780019726297.gitgitgadget@gmail.com> (Brandon Dong via GitGitGadget's message of "Fri, 29 May 2026 01:55:26 +0000")

"Brandon Dong via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Brandon <brandondong96@gmail.com>

As you identify yourself as "Brandon Dong" on the Signed-off-by line
below, please match this in-body From: line with it.

> Include mention of --message flag in merge docs to match what is
> accepted (builtin/merge.c) and to make it consistent with the git
> commit docs.
>
> Signed-off-by: Brandon Dong <brandondong96@gmail.com>
> ---
>     doc: add missing --message long option to merge docs
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2315%2Fbrandondong%2Fmerge_message_docs-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2315/brandondong/merge_message_docs-v1
> Pull-Request: https://github.com/git/git/pull/2315
>
>  Documentation/git-merge.adoc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/git-merge.adoc b/Documentation/git-merge.adoc
> index a055384ad6..6581f4c69c 100644
> --- a/Documentation/git-merge.adoc
> +++ b/Documentation/git-merge.adoc
> @@ -68,6 +68,7 @@ OPTIONS
>  include::merge-options.adoc[]
>  
>  `-m <msg>`::
> +`--message=<msg>`::
>  	Set the commit message to be used for the merge commit (in
>  	case one is created).
>  +

Hmph.  This is still not consistent with "git merge -h" output has,
which seems to accept --[no-]message as well.

It is not exactly your fault, but there are a few options other than
this one that support optional [no-] and they are not documented as
such, even though they appear in "git merge -h".  "git merge -m foo
--no-message other" behaves as if "GIT_EDITOR=: git merge other" was
run, it seems.

  reply	other threads:[~2026-05-29  5:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29  1:55 [PATCH] doc: add missing --message long option to merge docs Brandon Dong via GitGitGadget
2026-05-29  5:02 ` Junio C Hamano [this message]
2026-05-31  6:37   ` Brandon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo6hyiz9g.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=brandondong96@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox