From: Junio C Hamano <gitster@pobox.com>
To: "D. Ben Knoble" <ben.knoble@gmail.com>
Cc: Phillip Wood <phillip.wood123@gmail.com>,
Javier Bassi <javierbassi@gmail.com>,
git@vger.kernel.org,
Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>,
Rene Scharfe <l.s.r@web.de>, Elijah Newren <newren@gmail.com>,
Ruben Justo <rjusto@gmail.com>, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH] add -p: introduce 'w' command to view hunk with --word-diff
Date: Tue, 12 May 2026 09:04:10 +0900 [thread overview]
Message-ID: <xmqqo6ilqyrp.fsf@gitster.g> (raw)
In-Reply-To: <CALnO6CCR9bQ71LR_buEAzX4UcR4sERnaVLc6_19sJUfXyi-HPA@mail.gmail.com> (D. Ben Knoble's message of "Mon, 11 May 2026 15:16:48 -0400")
"D. Ben Knoble" <ben.knoble@gmail.com> writes:
>> > :show <opts>
> ...
> - ":" is an exception to single-key mode and always allows more text
> to compose a longer-form "command". The first command could be "print"
> which takes options of this kind.
>
> Since ":" would be new, exempting it from single-key mode shouldn't be
> too jarring I guess.
OK. And we can use ':blah' to rarely used actions and give them
descriptive names. Makes sense. word-diff sounds like a good
candidate but it is not immediately obvious to me if machinery to
set up the "colon is special and handles longhand commands with
possible arguments" is worth doing.
prev parent reply other threads:[~2026-05-12 0:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 23:54 [PATCH] add -p: introduce 'w' command to view hunk with --word-diff Javier Bassi
2026-05-07 7:55 ` Pablo
2026-05-07 13:24 ` Phillip Wood
2026-05-07 14:53 ` Pablo
2026-05-07 13:24 ` Phillip Wood
2026-05-07 14:39 ` D. Ben Knoble
2026-05-11 0:16 ` Junio C Hamano
2026-05-11 19:16 ` D. Ben Knoble
2026-05-12 0:04 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo6ilqyrp.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=abrahamadekunle50@gmail.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=javierbassi@gmail.com \
--cc=l.s.r@web.de \
--cc=newren@gmail.com \
--cc=phillip.wood123@gmail.com \
--cc=ps@pks.im \
--cc=rjusto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox