From: Junio C Hamano <gitster@pobox.com>
To: Mirko Faina <mroik@delayed.space>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] docs: fix --commit-list-format related entries
Date: Thu, 26 Mar 2026 14:10:12 -0700 [thread overview]
Message-ID: <xmqqo6kanvpn.fsf@gitster.g> (raw)
In-Reply-To: <acWbpJTRusOv6bPk@exploit> (Mirko Faina's message of "Thu, 26 Mar 2026 21:53:56 +0100")
Mirko Faina <mroik@delayed.space> writes:
> On Thu, Mar 26, 2026 at 01:45:15PM -0700, Junio C Hamano wrote:
>> Being verbose is usually a good way to discourage readers from
>> reading.
> ...
>> The use of this command line option implies `--cover-letter`,
>> unless explicitly countermanded with `--no-cover-letter`.
>
> this part in particular is no different than the original text:
>
> This option implies the use of `--cover-letter` unless
> `--no-cover-letter` is given.
>
> If we want to emphasize that the configuration variable doesn't imply
> --cover-letter, we have to add the note on `format.commitListFormat`.
I do not think so.
If we mention a variable, the readers would wonder if the variable
has effects. You can explicitly say that that it does *not* have
effect, but we are often better of not mentioning what is not
relevant.
next prev parent reply other threads:[~2026-03-26 21:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 18:55 [PATCH] docs: fix --commit-list-format related entries Mirko Faina
2026-03-26 19:10 ` Junio C Hamano
2026-03-26 20:06 ` [PATCH v2] " Mirko Faina
2026-03-26 20:45 ` Junio C Hamano
2026-03-26 20:53 ` Mirko Faina
2026-03-26 21:10 ` Junio C Hamano [this message]
2026-03-27 0:20 ` Mirko Faina
2026-03-27 0:25 ` Mirko Faina
2026-03-27 19:48 ` [PATCH 0/2] format-patch: remove wrapping and update docs Mirko Faina
2026-03-27 19:48 ` [PATCH 1/2] docs: fix --commit-list-format related entries Mirko Faina
2026-03-27 19:48 ` [PATCH 2/2] format-patch: removing unconditional wrapping Mirko Faina
2026-03-27 20:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo6kanvpn.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mroik@delayed.space \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox