From: Junio C Hamano <gitster@pobox.com>
To: Pablo Sabater <pabloosabaterr@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [GSoC PATCH] t9200: use helpers to replace test -f <path> and test -d <path>
Date: Mon, 09 Mar 2026 08:20:29 -0700 [thread overview]
Message-ID: <xmqqo6kx58si.fsf@gitster.g> (raw)
In-Reply-To: <20260309150935.578465-1-pabloosabaterr@gmail.com> (Pablo Sabater's message of "Mon, 9 Mar 2026 16:09:35 +0100")
Pablo Sabater <pabloosabaterr@gmail.com> writes:
> Replaced 'test -f' and 'test -d' with 'test_path_is_file' and 'test_path_is_dir'
>
> I've used 'git grep "test -f" t/t9*.sh' to find a file without the fix done as specified on the microproject information
> I've done '9*' because the ones I've found first had already fix patches.
> I've taken as example another patch sent 't4131' from Junio C Hamano https://lore.kernel.org/git/xmqq1rpodn25.fsf@gitster.c.googlers.com/#r
After studying Documentation/{SubmittingPatches,CodingGuidelines},
use the list archive to find what instructions GSoC participant
candidates have received regarding the proposed log messages in
their microproject submissions.
Thanks.
next prev parent reply other threads:[~2026-03-09 15:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 15:09 [GSoC PATCH] t9200: use helpers to replace test -f <path> and test -d <path> Pablo Sabater
2026-03-09 15:20 ` Junio C Hamano [this message]
2026-03-09 15:39 ` Pablo
2026-03-09 16:28 ` [GSoC PATCH v2] t9200: replace test -f/-d with modern path helpers Pablo Sabater
2026-03-09 21:03 ` Junio C Hamano
2026-03-09 22:54 ` Pablo
2026-03-09 23:01 ` [GSoC PATCH v3] " Pablo Sabater
2026-03-09 23:26 ` Junio C Hamano
2026-03-11 10:59 ` Pablo
2026-03-11 17:52 ` Junio C Hamano
2026-03-11 19:06 ` Pablo
2026-03-11 19:42 ` Junio C Hamano
2026-03-11 19:49 ` Pablo
2026-03-11 20:31 ` Junio C Hamano
2026-03-12 17:33 ` [GSoC PATCH v4] t9200: replace test -f with modern path helper Pablo Sabater
2026-03-12 17:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo6kx58si.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pabloosabaterr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox